Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-46

Refactor MasterTest to use fixture

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: test
    • Labels:

      Description

      master_test.cpp contains a lot of redundant code Master/Slave/SchedulerDriver setup code that should be refactored into a test fixture.

        Activity

        Hide
        woggle Charles Reiss added a comment -

        Patch attached; currently against github HEAD, which I hope will be the git mirror head by the time a reviewboard is set up.

        Show
        woggle Charles Reiss added a comment - Patch attached; currently against github HEAD, which I hope will be the git mirror head by the time a reviewboard is set up.
        Hide
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2664/
        -----------------------------------------------------------

        Review request for mesos.

        Summary
        -------

        This patch refactors MasterTest.* tests to use a test fixture, eliminating a bunch of redundant setup/teardown code. It also renames it to MasterSlaveTest to reflect that the current MasterTest actually tests both mesos::internal::master::Master and mesos::internal::slave::Slave together.

        [This is just an import of the diff in the JIRA issue into reviewboard.]

        This addresses bug MESOS-46.
        https://issues.apache.org/jira/browse/MESOS-46

        Diffs


        src/tests/master_tests.cpp 2438114

        Diff: https://reviews.apache.org/r/2664/diff

        Testing
        -------

        Thanks,

        Charles

        Show
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2664/ ----------------------------------------------------------- Review request for mesos. Summary ------- This patch refactors MasterTest.* tests to use a test fixture, eliminating a bunch of redundant setup/teardown code. It also renames it to MasterSlaveTest to reflect that the current MasterTest actually tests both mesos::internal::master::Master and mesos::internal::slave::Slave together. [This is just an import of the diff in the JIRA issue into reviewboard.] This addresses bug MESOS-46 . https://issues.apache.org/jira/browse/MESOS-46 Diffs src/tests/master_tests.cpp 2438114 Diff: https://reviews.apache.org/r/2664/diff Testing ------- Thanks, Charles
        Hide
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2664/
        -----------------------------------------------------------

        (Updated 2012-02-13 22:31:04.818047)

        Review request for mesos.

        Changes
        -------

        Merged with trunk.

        Summary (updated)
        -------

        This patch refactors MasterTest.* tests to use a test fixture, eliminating a bunch of redundant setup/teardown code. It also renames it to MasterSlaveTest to reflect that the current MasterTest actually tests both mesos::internal::master::Master and mesos::internal::slave::Slave together.

        This addresses bug MESOS-46.
        https://issues.apache.org/jira/browse/MESOS-46

        Diffs (updated)


        src/tests/master_tests.cpp a411ba5

        Diff: https://reviews.apache.org/r/2664/diff

        Testing
        -------

        Thanks,

        Charles

        Show
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2664/ ----------------------------------------------------------- (Updated 2012-02-13 22:31:04.818047) Review request for mesos. Changes ------- Merged with trunk. Summary (updated) ------- This patch refactors MasterTest.* tests to use a test fixture, eliminating a bunch of redundant setup/teardown code. It also renames it to MasterSlaveTest to reflect that the current MasterTest actually tests both mesos::internal::master::Master and mesos::internal::slave::Slave together. This addresses bug MESOS-46 . https://issues.apache.org/jira/browse/MESOS-46 Diffs (updated) src/tests/master_tests.cpp a411ba5 Diff: https://reviews.apache.org/r/2664/diff Testing ------- Thanks, Charles

          People

          • Assignee:
            benjaminhindman Benjamin Hindman
            Reporter:
            woggle Charles Reiss
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development