Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-4571

SlaveRecoveryTest.RecoverStatusUpdateManager is not consistent with its description

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.28.0
    • test

    Description

      The description is:

      The slave is killed before the update reaches the scheduler. When the slave comes back up it resends the unacknowledged update"
      

      But in the test code, the StatusUpdateMessage is dropped, so there is no checkpointing for status update involved at all. It's the executor resends the unacknowledged status updates when reconnecting, rather than the slave "resends the unacknowledged update". This means this test is the same with SlaveRecoveryTest.ReconnectExecutor, which doesn't make sense.

      To fix it, we should drop the StatusUpdateAcknowledgementMessage instead of the StatusUpdateMessage.

      Attachments

        Activity

          People

            lins05 Shuai Lin
            lins05 Shuai Lin
            Vinod Kone Vinod Kone
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: