[MESOS-4445] Labels equality behavior is wrong

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Labels: labels mesosphere
• Sprint: Mesosphere Sprint 28
• Story Points: 5
• Assignee: Unassigned
• Reporter: Neil Conway
• Shepherd: Michael Park
• Created: 20/Jan/16 21:18
• Updated: 26/Apr/17 16:53

Description

TEST(RevocableResourceTest, LabelSemantics)
{
  Labels labels1;
  Labels labels2;

  labels1.add_labels()->CopyFrom(createLabel("foo", "bar"));
  labels1.add_labels()->CopyFrom(createLabel("foo", "bar"));

  labels2.add_labels()->CopyFrom(createLabel("foo", "bar"));
  labels2.add_labels()->CopyFrom(createLabel("baz", "qux"));

  bool eq = (labels1 == labels2);
  LOG(INFO) << "Equal? " << (eq ? "true" : "false");
}

Output:

[ RUN      ] RevocableResourceTest.LabelSemantics
I0120 13:15:25.207223 2078158848 resources_tests.cpp:1990] Equal? true
[       OK ] RevocableResourceTest.LabelSemantics (0 ms)

This behavior seems pretty problematic.

Issue Links

• relates to: MESOS-2504 Upgrade protobuf to 2.6.1
• relates to: MESOS-4678 Upgrade vendored Protobuf to 2.6.1