[MESOS-4422] Use adaptor::reverse for reverse iteration in the code base.

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Assignee: haosdent
• Reporter: Jie Yu
• Created: 18/Jan/16 23:14
• Updated: 20/Jan/16 22:29
• Resolved: 20/Jan/16 22:29

Description

It would be good to be consistent on our looping structure.

Currently, we use foreach for forward iteration and use rbegin/rend for reverse iteration. We recently added adaptor::reverse (https://reviews.apache.org/r/42450) in stout, which allows us to do:

vector<int> input = {....};
foreach (int i, adaptor::reverse(input)) {
  ...
}

We should cleanup our code to consistently use this structure on reverse iteration.

jie$ grep -R rbegin src
src/common/protobuf_utils.cpp:  for (auto status = task.statuses().rbegin();
src/slave/containerizer/mesos/containerizer.cpp:  for (auto it = isolators.crbegin(); it != isolators.crend(); ++it) {