[MESOS-4202] Race in SSL socket shutdown

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.27.0
• Labels: libprocess mesosphere
• Target Version/s: 0.27.0
• Epic Link: SSL Tech Debt
• Sprint: Mesosphere Sprint 24
• Story Points: 5
• Assignee: Jojy Varghese
• Reporter: Jojy Varghese
• Shepherd: Joris Van Remoortere
• Created: 18/Dec/15 23:13
• Updated: 26/Nov/18 12:22
• Resolved: 26/Nov/18 12:22

Description

libprocess Socket shares the ownership of the file descriptor with libevent. In
the destructor of the libprocess libevent_ssl socket, we call ssl shutdown which
is executed asynchronously. This causes the libprocess socket file descriptor tobe closed (and possibly reused) when the same file descriptor could be used bylibevent/ssl. Since we set the shutdown options as SSL_RECEIVED_SHUTDOWN, we leave the any write operations to continue with possibly closed file descriptor.

This issue manifests as junk characters written to the file that has been handled the closed socket file descriptor (by OS) that has the above issue.

Issue Links

• is duplicated by: MESOS-3773 RegistryClientTest.SimpleGetBlob is flaky