Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-3963

Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.27.0
    • Component/s: fetcher
    • Labels:

      Description

      According to the google code style, the using should be used in internal namespace in header files. Grep the header files, only fetcher.hpp deserved a path.

      You may use a using-declaration anywhere in a .cc file (including in the global namespace), and in functions, methods, classes, or within internal namespaces in .h files.

      Do not use using-declarations in .h files except in explicitly marked internal-only namespaces, because anything imported into a namespace in a .h file becomes part of the public API exported by that file.

      // OK in .cc files.
      // Must be in a function, method, internal namespace, or
      // class in .h files.
      using ::foo::bar;
      

        Attachments

          Activity

            People

            • Assignee:
              klaus1982 Klaus Ma
              Reporter:
              klaus1982 Klaus Ma
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: