[MESOS-3712] --launcher_dir flag is not picked up when running health-checks

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 0.24.1, 0.25.0
• Component/s: agent
• Labels: containerizer mesosphere tech-debt

Environment

Ubuntu Linux x64

• Assignee: Unassigned
• Reporter: Jay Taylor
• Shepherd: Jay Taylor
• Created: 12/Oct/15 23:05
• Updated: 26/Nov/18 12:35
• Resolved: 26/Nov/18 12:35

Description

Mesos configuration flags are one-way and aren't expanded to their corresponding MESOS_ENV variable.

The MESOS_LAUNCHER_DIR however, is necessary here:

  const Option<string> envPath = os::getenv("MESOS_LAUNCHER_DIR");
  string path =
    envPath.isSome() ? envPath.get()
                     : os::realpath(Path(argv[0]).dirname()).get();

when the executor needs to resolve the path to run, for example, health-checks.

Instead of the passed-in argument argv[0] (which contains the Agent's --work_dir instead) is the path that ends up being used.

How can the requisite MESOS_LAUNCHER_DIR env var be available when docker/executor.cpp (a child process of mesos-slave) attempts to read it?

---

The relevant email thread is here:
http://www.mail-archive.com/[e-mail]/msg04794.html

Issue Links

• duplicates: MESOS-3738 Mesos health check is invoked incorrectly when Mesos slave is within the docker container