Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-3698

JSON parsing allows non-whitespace trailing characters

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.26.0
    • Component/s: None
    • Labels:
    • Sprint:
      Mesosphere Sprint 21
    • Story Points:
      1

      Description

      Picojson supports a streaming mode in which a stream containing a series of JSON values can be repeatedly parsed. For this reason, it does not return an error when passed a string containing a valid JSON value followed by non-whitespace trailing characters.

      However, in addition to the four-argument picojson::parse() that we're using, picojson contains a two-argument parse() function (https://github.com/kazuho/picojson/blob/master/picojson.h#L938-L942) which accepts a std::string and should probably validate its input to ensure it doesn't contain trailing characters. A pull request has been filed for this change at https://github.com/kazuho/picojson/pull/70 and if it's merged, we can switch to the two-argument function call. In the meantime, we should provide such input validation ourselves in JSON::parse().

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                greggomann Greg Mann
                Reporter:
                greggomann Greg Mann
                Shepherd:
                Adam B
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: