[MESOS-3055] Master doesn't properly handle SUBSCRIBE call

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.23.0
• Fix Version/s: 0.23.0
• Target Version/s: 0.23.0
• Epic Link: Scheduler API v1
• Sprint: Twitter Mesos Q3 Sprint 1
• Story Points: 2
• Assignee: Vinod Kone
• Reporter: Vinod Kone
• Shepherd: Benjamin Mahler
• Created: 15/Jul/15 17:20
• Updated: 16/Jul/15 22:34
• Resolved: 16/Jul/15 22:34

Description

Master::subscribe() incorrectly handles re-registration. It handles it as a registration request (not "re-registration") because of a bug in the if loop (should have been !frameworkInfo.has_id()).

void Master::subscribe(
    const UPID& from,
    const scheduler::Call::Subscribe& subscribe)
{
  const FrameworkInfo& frameworkInfo = subscribe.framework_info();

  // TODO(vinod): Instead of calling '(re-)registerFramework()' from
  // here refactor those methods to call 'subscribe()'.
  if (frameworkInfo.has_id() || frameworkInfo.id() == "") {
    registerFramework(from, frameworkInfo);
  } else {
    reregisterFramework(from, frameworkInfo, subscribe.force());
  }
}