[MESOS-2991] Compilation Error on Mac OS 10.10.4 with clang 3.5.0

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.23.0
• Fix Version/s: 0.23.0
• Component/s: stout, test
• Labels: mesosphere
• Target Version/s: 0.23.0
• Sprint: Mesosphere Sprint 14
• Story Points: 1
• Assignee: Michael Park
• Reporter: Alex R
• Shepherd: Adam B
• Created: 06/Jul/15 13:18
• Updated: 26/Nov/18 12:20
• Resolved: 26/Nov/18 12:20

Description

Compiling 0.23.0 (rc1) produces compilation errors on Mac OS 10.10.4 with g++ based on LLVM 3.5. It looks like the issue was introduced in a5640ad813e6256b548fca068f04fd9fa3a03eda, https://reviews.apache.org/r/32838. In contrast to the commit message, compiling the rc with gcc4.4 on CentOS worked fine for me.

According to 0.23 release notes and MESOS-2604, we should support clang 3.5.

../../../../../3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp:543:25: error: conversion from 'void ()' to 'const Option<void (*)()>' is ambiguous
                   Fork(dosetsid,          // Great-great-granchild.
                        ^~~~~~~~
../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp:40:3: note: candidate constructor
  Option(const T& _t) : state(SOME), t(_t) {}
  ^
../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp:42:3: note: candidate constructor
  Option(T&& _t) : state(SOME), t(std::move(_t)) {}
  ^
../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp:45:3: note: candidate constructor [with U = void ()]
  Option(const U& u) : state(SOME), t(u) {}
  ^

Compiler version:

$ g++ --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 6.0 (clang-600.0.54) (based on LLVM 3.5svn)
Target: x86_64-apple-darwin14.4.0
Thread model: posix

Issue Links

• is related to: MESOS-2943 mesos fails to compile under mac when libssl and libevent are enabled