[MESOS-2903] Network isolator should not fail when target state already exists

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Invalid
• Affects Version/s: 0.23.0
• Component/s: containerization
• Target Version/s: 0.23.0
• Sprint: Twitter Mesos Q2 Sprint 6
• Story Points: 3
• Assignee: Paul Brett
• Reporter: Paul Brett
• Created: 19/Jun/15 23:21
• Updated: 26/Apr/17 16:54
• Resolved: 22/Jun/15 21:29

Description

Network isolator has multiple instances of the following pattern:

  Try<bool> something = ....::create();                                  
  if (something.isError()) {                                                   
    ++metrics.something_errors;                                      
    return Failure("Failed to create something ...")
  } else if (!icmpVethToEth0.get()) {                                               
    ++metrics.adding_veth_icmp_filters_already_exist;                               
    return Failure("Something already exists");
  }                                                                                 

These failures have occurred in operation due to the failure to recover or delete an orphan, causing the slave to remain on line but unable to create new resources. We should convert the second failure message in this pattern to an information message since the final state of the system is the state that we requested.

Issue Links

• is related to: MESOS-2367 Improve slave resiliency in the face of orphan containers
• is related to: MESOS-2914 Port mapping isolator should cleanup unknown orphan containers after all known orphan containers are recovered during recovery.