[MESOS-2581] Document tips, best practices, guidelines for doing code reviews.

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Labels: tech-debt
• Sprint: Twitter Mesos Q1 Sprint 6, Twitter Q2 Sprint 1 - 4/13
• Story Points: 3
• Assignee: Benjamin Mahler
• Reporter: Benjamin Mahler
• Shepherd: Vinod Kone
• Created: 31/Mar/15 18:51
• Updated: 24/May/17 17:03
• Resolved: 23/Apr/15 23:09

Description

We currently have a "Committers Guide", however most of this information is relevant to all contributors looking to be participating in the code review process.

I'm proposing we extract much of this information into a more general "Code Reviewing" document, and include additional tips, best practices, lessons learned from members of the community.

This would be a great pre-requisite for on-boarding more committers and adding MAINTAINERS.

The committers guide can be more specific to our expectations of committers, so we may want to make this into a "committership" document to help set expectations for contributors looking to become committers.