Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-2314

remove unnecessary constants

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 0.22.0
    • None
    • Twitter Mesos Q1 Sprint 2
    • 2

    Description

      In src/slave/paths.cpp a number of string constants are defined to describe the formats of various paths. However, given there is a 1:1 mapping between the string constant and the functions that build the paths, the code would be more readable if the format strings were inline in the functions.

      In the cases where one constant depends on another (see the EXECUTOR_INFO_PATH, EXECUTOR_PATH, FRAMEWORK_PATH, SLAVE_PATH, ROOT_PATH chain, for example) the function calls can just be chained together.

      This will have the added benefit of removing some statically constructed string constants, which are dangerous.

      Attachments

        Issue Links

          Activity

            People

              dhamon Dominic Hamon
              dhamon Dominic Hamon
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: