Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-2038

Remove dead code in Slave::_runTask

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • 0.21.0
    • 0.21.0
    • agent
    • Mesosphere Q4 Sprint 2 - 11/14

    Description

      In the course of fixing MESOS-947, it has been overlooked by me that the code in question became dead code. Coverty caught this and Ben Mahler reported it.

      At the top of _runTask(), there is now a test whether framework is NULL and in each case it ever is before reaching the code in question (see below) there is a local exit from the method. So we should be able to remove this code without effect:

      • if (framework == NULL) { - framework = new Framework(this, frameworkId, frameworkInfo, pid); - frameworks[frameworkId] = framework; - }

        -

      • CHECK_NOTNULL(framework);
        -

      Attachments

        Activity

          People

            bernd-mesos Bernd Mathiske
            bernd-mesos Bernd Mathiske
            Benjamin Mahler Benjamin Mahler
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified