Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-1517

Maintain a queue of messages that arrive before the master recovers.

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: master

      Description

      Currently when the master is recovering, we drop all incoming messages. If slaves and frameworks knew about the leading master only once it has recovered, then we would only expect to see messages after we've recovered.

      We previously considered enqueuing all messages through the recovery future, but this has the downside of forcing all messages to go through the master's queue twice:

        // TODO(bmahler): Consider instead re-enqueing *all* messages
        // through recover(). What are the performance implications of
        // the additional queueing delay and the accumulated backlog
        // of messages post-recovery?
        if (!recovered.get().isReady()) {
          VLOG(1) << "Dropping '" << event.message->name << "' message since "
                  << "not recovered yet";
          ++metrics.dropped_messages;
          return;
        }
      

      However, an easy solution to this problem is to maintain an explicit queue of incoming messages that gets flushed once we finish recovery. This ensures that all messages post-recovery are processed normally.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              bmahler Benjamin Mahler
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: