[MESOS-1452] Improve Master::removeOffer to avoid further resource accounting bugs.

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: master
• Labels: resource-management
• Sprint: Resource Mgmt: RI-18 54
• Story Points: 3
• Assignee: Andrei Sekretenko
• Reporter: Benjamin Mahler
• Shepherd: Meng Zhu
• Created: 03/Jun/14 01:44
• Updated: 11/Sep/19 15:09
• Resolved: 09/Sep/19 11:59

Description

Per comments on this review: https://reviews.apache.org/r/21750/

We've had numerous bugs around resource accounting in the master due to the trickiness of removing offers in the Master code.

There are a few ways to improve this:

1. Add multiple offer methods to differentiate semantics:

useOffer(offerId);
rescindOffer(offerId);
discardOffer(offerId);

2. Add an enum to removeOffer to differentiate removal semantics:

removeOffer(offerId, USE);
removeOffer(offerId, RESCIND);
removeOffer(offerId, DISCARD);

Issue Links

• is depended upon by: MESOS-9949 Track allocated/offered in the allocator's role tree.
• relates to: MESOS-4553 Manage offers in allocator.