[MESOS-1356] Uncaught exceptions

• Type: Bug
• Status: Accepted
• Priority: Major
• Resolution: Unresolved
• Labels: coverity newbie
• Assignee: Michael Browning
• Reporter: Niklas Quarfot Nielsen
• Created: 13/May/14 15:39
• Updated: 03/Mar/16 07:11

Description

We usually do not use exceptions in Mesos, but some libraries may and we should handle them and perhaps convert them into Try<>/Error.

________________________________________________________________________________________________________

• • • CID 1213893: Uncaught exception (UNCAUGHT_EXCEPT)
      /src/slave/containerizer/linux_launcher.cpp: 148 in mesos::internal::slave::_childMain(const std::tr1::function<int ()> &, int *)()
      142 return (*func)();
      143 }
      144
      145
      146 // Helper that creates a new session then blocks on reading the pipe before
      147 // calling the supplied function.
      >>> CID 1213893: Uncaught exception (UNCAUGHT_EXCEPT)
      >>> In function "_childMain" an exception of type "std::tr1::bad_function_call" is thrown and never caught.
      148 static int _childMain(
      149 const lambda::function<int()>& childFunction,
      150 int pipes[2])
      151 { 152 // In child. 153 os::close(pipes[1]); ________________________________________________________________________________________________________ *** CID 1213894: Uncaught exception (UNCAUGHT_EXCEPT) /src/slave/containerizer/linux_launcher.cpp: 137 in mesos::internal::slave::childMain(void *)() 131 132 return Nothing(); 133 }

      134
      135
      136 // Helper for clone() which expects an int(void*).
      >>> CID 1213894: Uncaught exception (UNCAUGHT_EXCEPT)
      >>> In function "childMain" an exception of type "std::tr1::bad_function_call" is thrown and never caught.
      137 static int childMain(void* child)
      138

      { 139 const lambda::function<int()>* func = 140 static_cast<const lambda::function<int()>*> (child); 141 142 return (*func)(); ________________________________________________________________________________________________________ *** CID 1213895: Uncaught exception (UNCAUGHT_EXCEPT) /src/usage/main.cpp: 72 in main() 66 << endl 67 << "Supported options:" << endl 68 << flags.usage(); 69 }

      70
      71
      >>> CID 1213895: Uncaught exception (UNCAUGHT_EXCEPT)
      >>> In function "main" an exception of type "google::protobuf::FatalException" is thrown and never caught.
      72 int main(int argc, char** argv)
      73

      { 74 GOOGLE_PROTOBUF_VERIFY_VERSION; 75 76 Flags flags; 77 /src/usage/main.cpp: 72 in main() 66 << endl 67 << "Supported options:" << endl 68 << flags.usage(); 69 }

      70
      71
      >>> CID 1213895: Uncaught exception (UNCAUGHT_EXCEPT)
      >>> In function "main" an exception of type "google::protobuf::FatalException" is thrown and never caught.
      72 int main(int argc, char** argv)
      73

      { 74 GOOGLE_PROTOBUF_VERIFY_VERSION; 75 76 Flags flags; 77 /src/usage/main.cpp: 72 in main() 66 << endl 67 << "Supported options:" << endl 68 << flags.usage(); 69 }

      70
      71
      >>> CID 1213895: Uncaught exception (UNCAUGHT_EXCEPT)
      >>> In function "main" an exception of type "google::protobuf::FatalException" is thrown and never caught.
      72 int main(int argc, char** argv)
      73

      { 74 GOOGLE_PROTOBUF_VERIFY_VERSION; 75 76 Flags flags; 77 ________________________________________________________________________________________________________ *** CID 1213896: Uncaught exception (UNCAUGHT_EXCEPT) /src/launcher/executor.cpp: 423 in main() 417 }

      ;
      418
      419 } // namespace internal

      { 420 }

      // namespace mesos {
      421
      422
      >>> CID 1213896: Uncaught exception (UNCAUGHT_EXCEPT)
      >>> In function "main" an exception of type "std::tr1::bad_function_call" is thrown and never caught.
      423 int main(int argc, char** argv)
      424 {
      425 mesos::internal::CommandExecutor executor;
      426 mesos::MesosExecutorDriver driver(&executor);
      427 return driver.run() == mesos::DRIVER_STOPPED ? 0 : 1;