Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Activity

      Benjamin Hindman created issue -
      Hide
      Benjamin Hindman added a comment -

      The general plan for this is to include the tar.gz of each third_party package rather than the source. Then probably the configure.ac will need to untar them (if they are configured to be used in the build directory. Some CPPFLAGS may need to be adjusted to deal with the fact that sources will no longer live in $(top_srcdir).

      I think that there are some files that have recently been added that will need to be made part of the distribution, possibly by EXTRA_DIST. In addition, I think include/scheduler.hpp and include/executor.hpp is missing.

      Show
      Benjamin Hindman added a comment - The general plan for this is to include the tar.gz of each third_party package rather than the source. Then probably the configure.ac will need to untar them (if they are configured to be used in the build directory. Some CPPFLAGS may need to be adjusted to deal with the fact that sources will no longer live in $(top_srcdir). I think that there are some files that have recently been added that will need to be made part of the distribution, possibly by EXTRA_DIST. In addition, I think include/scheduler.hpp and include/executor.hpp is missing.
      Hide
      Benjamin Hindman added a comment -

      Also, it's possible that at least for the included ZooKeeper we'll also need to run 'ant compile_jute' ... which is kind of a pain.

      Show
      Benjamin Hindman added a comment - Also, it's possible that at least for the included ZooKeeper we'll also need to run 'ant compile_jute' ... which is kind of a pain.
      Charles Reiss made changes -
      Field Original Value New Value
      Assignee Charles Reiss [ woggle ]
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3587/
      -----------------------------------------------------------

      Review request for mesos.

      Summary
      -------

      'make clean' is currently missing a few generated files; this adds them.

      Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.

      Part of MESOS-120 because this is necessary for 'make distcheck' to pass.

      This addresses bug MESOS-120.
      https://issues.apache.org/jira/browse/MESOS-120

      Diffs


      src/Makefile.am b8fc58e

      Diff: https://reviews.apache.org/r/3587/diff

      Testing
      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/ ----------------------------------------------------------- Review request for mesos. Summary ------- 'make clean' is currently missing a few generated files; this adds them. Also makes mesos_pb2.py be generated directly in python/src instead of being copied there. Part of MESOS-120 because this is necessary for 'make distcheck' to pass. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs src/Makefile.am b8fc58e Diff: https://reviews.apache.org/r/3587/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3588/
      -----------------------------------------------------------

      Review request for mesos.

      Summary
      -------

      Builds third_party from tarballs instead of having us distribute the unpacked source.

      To make it sane to review, this patch does not include the tarballs or the removal of the original third_party directories. Everything but distribute-* should be put into tarballs for this to work.

      This addresses bug MESOS-120.
      https://issues.apache.org/jira/browse/MESOS-120

      Diffs


      Makefile.am f26e555
      configure.ac bda6769
      src/Makefile.am b8fc58e
      src/python/setup.py.in 07aaa58
      src/tests/base_zookeeper_test.cpp 872bffb
      third_party/Makefile.am PRE-CREATION

      Diff: https://reviews.apache.org/r/3588/diff

      Testing
      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3588/ ----------------------------------------------------------- Review request for mesos. Summary ------- Builds third_party from tarballs instead of having us distribute the unpacked source. To make it sane to review, this patch does not include the tarballs or the removal of the original third_party directories. Everything but distribute-* should be put into tarballs for this to work. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs Makefile.am f26e555 configure.ac bda6769 src/Makefile.am b8fc58e src/python/setup.py.in 07aaa58 src/tests/base_zookeeper_test.cpp 872bffb third_party/Makefile.am PRE-CREATION Diff: https://reviews.apache.org/r/3588/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3588/
      -----------------------------------------------------------

      (Updated 2012-01-23 08:26:57.656078)

      Review request for mesos.

      Changes
      -------

      Revised patch, fixes:

      Avoid building protobuf twice in parallel when make -j N is used.

      Specify the correct distribute path when building protobuf egg.

      Summary
      -------

      Builds third_party from tarballs instead of having us distribute the unpacked source.

      To make it sane to review, this patch does not include the tarballs or the removal of the original third_party directories. Everything but distribute-* should be put into tarballs for this to work.

      This addresses bug MESOS-120.
      https://issues.apache.org/jira/browse/MESOS-120

      Diffs (updated)


      Makefile.am f26e555
      configure.ac bda6769
      src/Makefile.am b8fc58e
      src/python/setup.py.in 07aaa58
      src/tests/base_zookeeper_test.cpp 872bffb
      third_party/Makefile.am PRE-CREATION

      Diff: https://reviews.apache.org/r/3588/diff

      Testing
      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3588/ ----------------------------------------------------------- (Updated 2012-01-23 08:26:57.656078) Review request for mesos. Changes ------- Revised patch, fixes: Avoid building protobuf twice in parallel when make -j N is used. Specify the correct distribute path when building protobuf egg. Summary ------- Builds third_party from tarballs instead of having us distribute the unpacked source. To make it sane to review, this patch does not include the tarballs or the removal of the original third_party directories. Everything but distribute-* should be put into tarballs for this to work. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs (updated) Makefile.am f26e555 configure.ac bda6769 src/Makefile.am b8fc58e src/python/setup.py.in 07aaa58 src/tests/base_zookeeper_test.cpp 872bffb third_party/Makefile.am PRE-CREATION Diff: https://reviews.apache.org/r/3588/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3587/#review4561
      -----------------------------------------------------------

      Just a few quick questions.

      src/Makefile.am
      <https://reviews.apache.org/r/3587/#comment10183>

      If we don't build with java, does 'make clean' complain if these don't exist? What's the cons to sticking all the clean stuff (including the clean-java/clean-python) targets within 'if HAS_JAVA' (or 'if HAS_PYTHON')?

      src/Makefile.am
      <https://reviews.apache.org/r/3587/#comment10182>

      Why is this needed?

      src/Makefile.am
      <https://reviews.apache.org/r/3587/#comment10184>

      Does 'make check' create the test_output directory?

      • Benjamin

      On 2012-01-23 03:33:37, Charles Reiss wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/3587/

      -----------------------------------------------------------

      (Updated 2012-01-23 03:33:37)

      Review request for mesos.

      Summary

      -------

      'make clean' is currently missing a few generated files; this adds them.

      Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.

      Part of MESOS-120 because this is necessary for 'make distcheck' to pass.

      This addresses bug MESOS-120.

      https://issues.apache.org/jira/browse/MESOS-120

      Diffs

      -----

      src/Makefile.am b8fc58e

      Diff: https://reviews.apache.org/r/3587/diff

      Testing

      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/#review4561 ----------------------------------------------------------- Just a few quick questions. src/Makefile.am < https://reviews.apache.org/r/3587/#comment10183 > If we don't build with java, does 'make clean' complain if these don't exist? What's the cons to sticking all the clean stuff (including the clean-java/clean-python) targets within 'if HAS_JAVA' (or 'if HAS_PYTHON')? src/Makefile.am < https://reviews.apache.org/r/3587/#comment10182 > Why is this needed? src/Makefile.am < https://reviews.apache.org/r/3587/#comment10184 > Does 'make check' create the test_output directory? Benjamin On 2012-01-23 03:33:37, Charles Reiss wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/ ----------------------------------------------------------- (Updated 2012-01-23 03:33:37) Review request for mesos. Summary ------- 'make clean' is currently missing a few generated files; this adds them. Also makes mesos_pb2.py be generated directly in python/src instead of being copied there. Part of MESOS-120 because this is necessary for 'make distcheck' to pass. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs ----- src/Makefile.am b8fc58e Diff: https://reviews.apache.org/r/3587/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      On 2012-01-24 21:23:29, Benjamin Hindman wrote:

      > src/Makefile.am, line 387

      > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line387>

      >

      > If we don't build with java, does 'make clean' complain if these don't exist? What's the cons to sticking all the clean stuff (including the clean-java/clean-python) targets within 'if HAS_JAVA' (or 'if HAS_PYTHON')?

      make clean needs to work even if you didn't build, so it shouldn't.

      On 2012-01-24 21:23:29, Benjamin Hindman wrote:

      > src/Makefile.am, line 677

      > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line677>

      >

      > Does 'make check' create the test_output directory?

      The external tests create it somehow, I don't know the exact mechanism offhand.

      On 2012-01-24 21:23:29, Benjamin Hindman wrote:

      > src/Makefile.am, line 508

      > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line508>

      >

      > Why is this needed?

      The distribution will tar most things up without write permission set. cp -pf will preserve this, so python/native will contain many read-only files.

      • Charles

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3587/#review4561
      -----------------------------------------------------------

      On 2012-01-23 03:33:37, Charles Reiss wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/3587/

      -----------------------------------------------------------

      (Updated 2012-01-23 03:33:37)

      Review request for mesos.

      Summary

      -------

      'make clean' is currently missing a few generated files; this adds them.

      Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.

      Part of MESOS-120 because this is necessary for 'make distcheck' to pass.

      This addresses bug MESOS-120.

      https://issues.apache.org/jira/browse/MESOS-120

      Diffs

      -----

      src/Makefile.am b8fc58e

      Diff: https://reviews.apache.org/r/3587/diff

      Testing

      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - On 2012-01-24 21:23:29, Benjamin Hindman wrote: > src/Makefile.am, line 387 > < https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line387 > > > If we don't build with java, does 'make clean' complain if these don't exist? What's the cons to sticking all the clean stuff (including the clean-java/clean-python) targets within 'if HAS_JAVA' (or 'if HAS_PYTHON')? make clean needs to work even if you didn't build, so it shouldn't. On 2012-01-24 21:23:29, Benjamin Hindman wrote: > src/Makefile.am, line 677 > < https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line677 > > > Does 'make check' create the test_output directory? The external tests create it somehow, I don't know the exact mechanism offhand. On 2012-01-24 21:23:29, Benjamin Hindman wrote: > src/Makefile.am, line 508 > < https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line508 > > > Why is this needed? The distribution will tar most things up without write permission set. cp -pf will preserve this, so python/native will contain many read-only files. Charles ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/#review4561 ----------------------------------------------------------- On 2012-01-23 03:33:37, Charles Reiss wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/ ----------------------------------------------------------- (Updated 2012-01-23 03:33:37) Review request for mesos. Summary ------- 'make clean' is currently missing a few generated files; this adds them. Also makes mesos_pb2.py be generated directly in python/src instead of being copied there. Part of MESOS-120 because this is necessary for 'make distcheck' to pass. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs ----- src/Makefile.am b8fc58e Diff: https://reviews.apache.org/r/3587/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      On 2012-01-24 21:23:29, Benjamin Hindman wrote:

      > src/Makefile.am, line 387

      > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line387>

      >

      > If we don't build with java, does 'make clean' complain if these don't exist? What's the cons to sticking all the clean stuff (including the clean-java/clean-python) targets within 'if HAS_JAVA' (or 'if HAS_PYTHON')?

      Charles Reiss wrote:

      make clean needs to work even if you didn't build, so it shouldn't.

      If we need 'clean-java' to be outside of the 'if HAS_JAVA' block, then I think it should be at the bottom of that block to make it easier to understand. Likewise, we can put CLEANFILES for MESOS_JAR and EXAMPLES_JAR inside the if HAS_JAVA block next to their targets (in fact, I think MESOS_JAR was already there, but not by itself). Likewise, I'd like to move the clean-python one too.

      On 2012-01-24 21:23:29, Benjamin Hindman wrote:

      > src/Makefile.am, line 508

      > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line508>

      >

      > Why is this needed?

      Charles Reiss wrote:

      The distribution will tar most things up without write permission set. cp -pf will preserve this, so python/native will contain many read-only files.

      Gotcha, thanks.

      On 2012-01-24 21:23:29, Benjamin Hindman wrote:

      > src/Makefile.am, line 677

      > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line677>

      >

      > Does 'make check' create the test_output directory?

      Charles Reiss wrote:

      The external tests create it somehow, I don't know the exact mechanism offhand.

      Right.

      • Benjamin

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3587/#review4561
      -----------------------------------------------------------

      On 2012-01-23 03:33:37, Charles Reiss wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/3587/

      -----------------------------------------------------------

      (Updated 2012-01-23 03:33:37)

      Review request for mesos.

      Summary

      -------

      'make clean' is currently missing a few generated files; this adds them.

      Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.

      Part of MESOS-120 because this is necessary for 'make distcheck' to pass.

      This addresses bug MESOS-120.

      https://issues.apache.org/jira/browse/MESOS-120

      Diffs

      -----

      src/Makefile.am b8fc58e

      Diff: https://reviews.apache.org/r/3587/diff

      Testing

      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - On 2012-01-24 21:23:29, Benjamin Hindman wrote: > src/Makefile.am, line 387 > < https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line387 > > > If we don't build with java, does 'make clean' complain if these don't exist? What's the cons to sticking all the clean stuff (including the clean-java/clean-python) targets within 'if HAS_JAVA' (or 'if HAS_PYTHON')? Charles Reiss wrote: make clean needs to work even if you didn't build, so it shouldn't. If we need 'clean-java' to be outside of the 'if HAS_JAVA' block, then I think it should be at the bottom of that block to make it easier to understand. Likewise, we can put CLEANFILES for MESOS_JAR and EXAMPLES_JAR inside the if HAS_JAVA block next to their targets (in fact, I think MESOS_JAR was already there, but not by itself). Likewise, I'd like to move the clean-python one too. On 2012-01-24 21:23:29, Benjamin Hindman wrote: > src/Makefile.am, line 508 > < https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line508 > > > Why is this needed? Charles Reiss wrote: The distribution will tar most things up without write permission set. cp -pf will preserve this, so python/native will contain many read-only files. Gotcha, thanks. On 2012-01-24 21:23:29, Benjamin Hindman wrote: > src/Makefile.am, line 677 > < https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line677 > > > Does 'make check' create the test_output directory? Charles Reiss wrote: The external tests create it somehow, I don't know the exact mechanism offhand. Right. Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/#review4561 ----------------------------------------------------------- On 2012-01-23 03:33:37, Charles Reiss wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/ ----------------------------------------------------------- (Updated 2012-01-23 03:33:37) Review request for mesos. Summary ------- 'make clean' is currently missing a few generated files; this adds them. Also makes mesos_pb2.py be generated directly in python/src instead of being copied there. Part of MESOS-120 because this is necessary for 'make distcheck' to pass. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs ----- src/Makefile.am b8fc58e Diff: https://reviews.apache.org/r/3587/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3587/
      -----------------------------------------------------------

      (Updated 2012-01-26 02:23:30.841463)

      Review request for mesos.

      Summary
      -------

      'make clean' is currently missing a few generated files; this adds them.

      Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.

      Part of MESOS-120 because this is necessary for 'make distcheck' to pass.

      This addresses bug MESOS-120.
      https://issues.apache.org/jira/browse/MESOS-120

      Diffs (updated)


      src/Makefile.am 48727ae

      Diff: https://reviews.apache.org/r/3587/diff

      Testing
      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/ ----------------------------------------------------------- (Updated 2012-01-26 02:23:30.841463) Review request for mesos. Summary ------- 'make clean' is currently missing a few generated files; this adds them. Also makes mesos_pb2.py be generated directly in python/src instead of being copied there. Part of MESOS-120 because this is necessary for 'make distcheck' to pass. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs (updated) src/Makefile.am 48727ae Diff: https://reviews.apache.org/r/3587/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      On 2012-01-24 21:23:29, Benjamin Hindman wrote:

      > src/Makefile.am, line 387

      > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line387>

      >

      > If we don't build with java, does 'make clean' complain if these don't exist? What's the cons to sticking all the clean stuff (including the clean-java/clean-python) targets within 'if HAS_JAVA' (or 'if HAS_PYTHON')?

      Charles Reiss wrote:

      make clean needs to work even if you didn't build, so it shouldn't.

      Benjamin Hindman wrote:

      If we need 'clean-java' to be outside of the 'if HAS_JAVA' block, then I think it should be at the bottom of that block to make it easier to understand. Likewise, we can put CLEANFILES for MESOS_JAR and EXAMPLES_JAR inside the if HAS_JAVA block next to their targets (in fact, I think MESOS_JAR was already there, but not by itself). Likewise, I'd like to move the clean-python one too.

      Moved clean-java and clean-python blocks to after the HAS_* blocks, and CLEANFILES additions to the HAS_* blocks.

      • Charles

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3587/#review4561
      -----------------------------------------------------------

      On 2012-01-26 02:23:30, Charles Reiss wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/3587/

      -----------------------------------------------------------

      (Updated 2012-01-26 02:23:30)

      Review request for mesos.

      Summary

      -------

      'make clean' is currently missing a few generated files; this adds them.

      Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.

      Part of MESOS-120 because this is necessary for 'make distcheck' to pass.

      This addresses bug MESOS-120.

      https://issues.apache.org/jira/browse/MESOS-120

      Diffs

      -----

      src/Makefile.am 48727ae

      Diff: https://reviews.apache.org/r/3587/diff

      Testing

      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - On 2012-01-24 21:23:29, Benjamin Hindman wrote: > src/Makefile.am, line 387 > < https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line387 > > > If we don't build with java, does 'make clean' complain if these don't exist? What's the cons to sticking all the clean stuff (including the clean-java/clean-python) targets within 'if HAS_JAVA' (or 'if HAS_PYTHON')? Charles Reiss wrote: make clean needs to work even if you didn't build, so it shouldn't. Benjamin Hindman wrote: If we need 'clean-java' to be outside of the 'if HAS_JAVA' block, then I think it should be at the bottom of that block to make it easier to understand. Likewise, we can put CLEANFILES for MESOS_JAR and EXAMPLES_JAR inside the if HAS_JAVA block next to their targets (in fact, I think MESOS_JAR was already there, but not by itself). Likewise, I'd like to move the clean-python one too. Moved clean-java and clean-python blocks to after the HAS_* blocks, and CLEANFILES additions to the HAS_* blocks. Charles ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/#review4561 ----------------------------------------------------------- On 2012-01-26 02:23:30, Charles Reiss wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/ ----------------------------------------------------------- (Updated 2012-01-26 02:23:30) Review request for mesos. Summary ------- 'make clean' is currently missing a few generated files; this adds them. Also makes mesos_pb2.py be generated directly in python/src instead of being copied there. Part of MESOS-120 because this is necessary for 'make distcheck' to pass. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs ----- src/Makefile.am 48727ae Diff: https://reviews.apache.org/r/3587/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3587/#review4628
      -----------------------------------------------------------

      Ship it!

      Cool, I'll get this committed.

      • Benjamin

      On 2012-01-26 02:23:30, Charles Reiss wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/3587/

      -----------------------------------------------------------

      (Updated 2012-01-26 02:23:30)

      Review request for mesos.

      Summary

      -------

      'make clean' is currently missing a few generated files; this adds them.

      Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.

      Part of MESOS-120 because this is necessary for 'make distcheck' to pass.

      This addresses bug MESOS-120.

      https://issues.apache.org/jira/browse/MESOS-120

      Diffs

      -----

      src/Makefile.am 48727ae

      Diff: https://reviews.apache.org/r/3587/diff

      Testing

      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/#review4628 ----------------------------------------------------------- Ship it! Cool, I'll get this committed. Benjamin On 2012-01-26 02:23:30, Charles Reiss wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/ ----------------------------------------------------------- (Updated 2012-01-26 02:23:30) Review request for mesos. Summary ------- 'make clean' is currently missing a few generated files; this adds them. Also makes mesos_pb2.py be generated directly in python/src instead of being copied there. Part of MESOS-120 because this is necessary for 'make distcheck' to pass. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs ----- src/Makefile.am 48727ae Diff: https://reviews.apache.org/r/3587/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3587/#review4723
      -----------------------------------------------------------

      src/Makefile.am
      <https://reviews.apache.org/r/3587/#comment10439>

      So we can kill this line now correct?

      • Benjamin

      On 2012-01-26 02:23:30, Charles Reiss wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/3587/

      -----------------------------------------------------------

      (Updated 2012-01-26 02:23:30)

      Review request for mesos.

      Summary

      -------

      'make clean' is currently missing a few generated files; this adds them.

      Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.

      Part of MESOS-120 because this is necessary for 'make distcheck' to pass.

      This addresses bug MESOS-120.

      https://issues.apache.org/jira/browse/MESOS-120

      Diffs

      -----

      src/Makefile.am 48727ae

      Diff: https://reviews.apache.org/r/3587/diff

      Testing

      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/#review4723 ----------------------------------------------------------- src/Makefile.am < https://reviews.apache.org/r/3587/#comment10439 > So we can kill this line now correct? Benjamin On 2012-01-26 02:23:30, Charles Reiss wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/ ----------------------------------------------------------- (Updated 2012-01-26 02:23:30) Review request for mesos. Summary ------- 'make clean' is currently missing a few generated files; this adds them. Also makes mesos_pb2.py be generated directly in python/src instead of being copied there. Part of MESOS-120 because this is necessary for 'make distcheck' to pass. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs ----- src/Makefile.am 48727ae Diff: https://reviews.apache.org/r/3587/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3588/#review4725
      -----------------------------------------------------------

      src/Makefile.am
      <https://reviews.apache.org/r/3588/#comment10445>

      s/move/Move and kill tab (or indentation).

      src/Makefile.am
      <https://reviews.apache.org/r/3588/#comment10446>

      Wrap for 80 characters please.

      src/Makefile.am
      <https://reviews.apache.org/r/3588/#comment10447>

      I've replaced '$(top_builddir)' with '..' everywhere else in the file.

      third_party/Makefile.am
      <https://reviews.apache.org/r/3588/#comment10450>

      I'd love to see some documentation here explaining our strategy for third_party, and why we decided to do it this way. Also, we need the license here too.

      third_party/Makefile.am
      <https://reviews.apache.org/r/3588/#comment10448>

      Not used.

      third_party/Makefile.am
      <https://reviews.apache.org/r/3588/#comment10449>

      Why @SUBCONFIG_ARGS@ instead of $(SUBCONFIG_ARGS)?

      third_party/Makefile.am
      <https://reviews.apache.org/r/3588/#comment10443>

      Wrap for 80 characters please (and everywhere else in this file).

      third_party/Makefile.am
      <https://reviews.apache.org/r/3588/#comment10442>

      Kill tab.

      • Benjamin

      On 2012-01-23 08:26:57, Charles Reiss wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/3588/

      -----------------------------------------------------------

      (Updated 2012-01-23 08:26:57)

      Review request for mesos.

      Summary

      -------

      Builds third_party from tarballs instead of having us distribute the unpacked source.

      To make it sane to review, this patch does not include the tarballs or the removal of the original third_party directories. Everything but distribute-* should be put into tarballs for this to work.

      This addresses bug MESOS-120.

      https://issues.apache.org/jira/browse/MESOS-120

      Diffs

      -----

      Makefile.am f26e555

      configure.ac bda6769

      src/Makefile.am b8fc58e

      src/python/setup.py.in 07aaa58

      src/tests/base_zookeeper_test.cpp 872bffb

      third_party/Makefile.am PRE-CREATION

      Diff: https://reviews.apache.org/r/3588/diff

      Testing

      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3588/#review4725 ----------------------------------------------------------- src/Makefile.am < https://reviews.apache.org/r/3588/#comment10445 > s/move/Move and kill tab (or indentation). src/Makefile.am < https://reviews.apache.org/r/3588/#comment10446 > Wrap for 80 characters please. src/Makefile.am < https://reviews.apache.org/r/3588/#comment10447 > I've replaced '$(top_builddir)' with '..' everywhere else in the file. third_party/Makefile.am < https://reviews.apache.org/r/3588/#comment10450 > I'd love to see some documentation here explaining our strategy for third_party, and why we decided to do it this way. Also, we need the license here too. third_party/Makefile.am < https://reviews.apache.org/r/3588/#comment10448 > Not used. third_party/Makefile.am < https://reviews.apache.org/r/3588/#comment10449 > Why @SUBCONFIG_ARGS@ instead of $(SUBCONFIG_ARGS)? third_party/Makefile.am < https://reviews.apache.org/r/3588/#comment10443 > Wrap for 80 characters please (and everywhere else in this file). third_party/Makefile.am < https://reviews.apache.org/r/3588/#comment10442 > Kill tab. Benjamin On 2012-01-23 08:26:57, Charles Reiss wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3588/ ----------------------------------------------------------- (Updated 2012-01-23 08:26:57) Review request for mesos. Summary ------- Builds third_party from tarballs instead of having us distribute the unpacked source. To make it sane to review, this patch does not include the tarballs or the removal of the original third_party directories. Everything but distribute-* should be put into tarballs for this to work. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs ----- Makefile.am f26e555 configure.ac bda6769 src/Makefile.am b8fc58e src/python/setup.py.in 07aaa58 src/tests/base_zookeeper_test.cpp 872bffb third_party/Makefile.am PRE-CREATION Diff: https://reviews.apache.org/r/3588/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3587/
      -----------------------------------------------------------

      (Updated 2012-02-01 00:35:56.677615)

      Review request for mesos.

      Summary
      -------

      'make clean' is currently missing a few generated files; this adds them.

      Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.

      Part of MESOS-120 because this is necessary for 'make distcheck' to pass.

      This addresses bug MESOS-120.
      https://issues.apache.org/jira/browse/MESOS-120

      Diffs (updated)


      src/Makefile.am 48727ae

      Diff: https://reviews.apache.org/r/3587/diff

      Testing
      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/ ----------------------------------------------------------- (Updated 2012-02-01 00:35:56.677615) Review request for mesos. Summary ------- 'make clean' is currently missing a few generated files; this adds them. Also makes mesos_pb2.py be generated directly in python/src instead of being copied there. Part of MESOS-120 because this is necessary for 'make distcheck' to pass. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs (updated) src/Makefile.am 48727ae Diff: https://reviews.apache.org/r/3587/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      On 2012-01-31 23:59:33, Benjamin Hindman wrote:

      > src/Makefile.am, line 547

      > <https://reviews.apache.org/r/3587/diff/2/?file=70825#file70825line547>

      >

      > So we can kill this line now correct?

      Yes. Done.

      • Charles

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3587/#review4723
      -----------------------------------------------------------

      On 2012-02-01 00:35:56, Charles Reiss wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/3587/

      -----------------------------------------------------------

      (Updated 2012-02-01 00:35:56)

      Review request for mesos.

      Summary

      -------

      'make clean' is currently missing a few generated files; this adds them.

      Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.

      Part of MESOS-120 because this is necessary for 'make distcheck' to pass.

      This addresses bug MESOS-120.

      https://issues.apache.org/jira/browse/MESOS-120

      Diffs

      -----

      src/Makefile.am 48727ae

      Diff: https://reviews.apache.org/r/3587/diff

      Testing

      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - On 2012-01-31 23:59:33, Benjamin Hindman wrote: > src/Makefile.am, line 547 > < https://reviews.apache.org/r/3587/diff/2/?file=70825#file70825line547 > > > So we can kill this line now correct? Yes. Done. Charles ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/#review4723 ----------------------------------------------------------- On 2012-02-01 00:35:56, Charles Reiss wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/ ----------------------------------------------------------- (Updated 2012-02-01 00:35:56) Review request for mesos. Summary ------- 'make clean' is currently missing a few generated files; this adds them. Also makes mesos_pb2.py be generated directly in python/src instead of being copied there. Part of MESOS-120 because this is necessary for 'make distcheck' to pass. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs ----- src/Makefile.am 48727ae Diff: https://reviews.apache.org/r/3587/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3587/#review4728
      -----------------------------------------------------------

      Ship it!

      Okay, I'm really submitting it this time.

      • Benjamin

      On 2012-02-01 00:35:56, Charles Reiss wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/3587/

      -----------------------------------------------------------

      (Updated 2012-02-01 00:35:56)

      Review request for mesos.

      Summary

      -------

      'make clean' is currently missing a few generated files; this adds them.

      Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.

      Part of MESOS-120 because this is necessary for 'make distcheck' to pass.

      This addresses bug MESOS-120.

      https://issues.apache.org/jira/browse/MESOS-120

      Diffs

      -----

      src/Makefile.am 48727ae

      Diff: https://reviews.apache.org/r/3587/diff

      Testing

      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/#review4728 ----------------------------------------------------------- Ship it! Okay, I'm really submitting it this time. Benjamin On 2012-02-01 00:35:56, Charles Reiss wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3587/ ----------------------------------------------------------- (Updated 2012-02-01 00:35:56) Review request for mesos. Summary ------- 'make clean' is currently missing a few generated files; this adds them. Also makes mesos_pb2.py be generated directly in python/src instead of being copied there. Part of MESOS-120 because this is necessary for 'make distcheck' to pass. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs ----- src/Makefile.am 48727ae Diff: https://reviews.apache.org/r/3587/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      On 2012-02-01 00:19:15, Benjamin Hindman wrote:

      > third_party/Makefile.am, line 4

      > <https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line4>

      >

      > Why @SUBCONFIG_ARGS@ instead of $(SUBCONFIG_ARGS)?

      That would be recursive on this line (since we are defining SUBCONFIG_ARGS for make purposes but not .in substitution purposes).

      On 2012-02-01 00:19:15, Benjamin Hindman wrote:

      > src/Makefile.am, lines 22-23

      > <https://reviews.apache.org/r/3588/diff/3/?file=70274#file70274line22>

      >

      > s/move/Move and kill tab (or indentation).

      Done.

      On 2012-02-01 00:19:15, Benjamin Hindman wrote:

      > third_party/Makefile.am, line 2

      > <https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line2>

      >

      > Not used.

      Removed.

      On 2012-02-01 00:19:15, Benjamin Hindman wrote:

      > third_party/Makefile.am, line 73

      > <https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line73>

      >

      > Kill tab.

      Done.

      On 2012-02-01 00:19:15, Benjamin Hindman wrote:

      > third_party/Makefile.am, line 48

      > <https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line48>

      >

      > Wrap for 80 characters please (and everywhere else in this file).

      Done.

      On 2012-02-01 00:19:15, Benjamin Hindman wrote:

      > src/Makefile.am, line 45

      > <https://reviews.apache.org/r/3588/diff/3/?file=70274#file70274line45>

      >

      > Wrap for 80 characters please.

      Done.

      On 2012-02-01 00:19:15, Benjamin Hindman wrote:

      > src/Makefile.am, lines 77-78

      > <https://reviews.apache.org/r/3588/diff/3/?file=70274#file70274line77>

      >

      > I've replaced '$(top_builddir)' with '..' everywhere else in the file.

      You haven't, but replaced my additions of $(top_builddir) with ..

      • Charles

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3588/#review4725
      -----------------------------------------------------------

      On 2012-02-01 02:25:11, Charles Reiss wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/3588/

      -----------------------------------------------------------

      (Updated 2012-02-01 02:25:11)

      Review request for mesos.

      Summary

      -------

      Builds third_party from tarballs instead of having us distribute the unpacked source.

      To make it sane to review, this patch does not include the tarballs or the removal of the original third_party directories. Everything but distribute-* should be put into tarballs for this to work.

      This addresses bug MESOS-120.

      https://issues.apache.org/jira/browse/MESOS-120

      Diffs

      -----

      Makefile.am d979bbb

      Makefile.am d979bbb

      configure.ac 283b49a

      configure.ac 283b49a

      src/Makefile.am ac0a209

      src/Makefile.am ac0a209

      src/examples/python/test-executor.in d730116

      src/examples/python/test-executor.in d730116

      src/examples/python/test-framework.in 0f6a6a9

      src/examples/python/test-framework.in 0f6a6a9

      src/python/setup.py.in 07aaa58

      src/python/setup.py.in 07aaa58

      src/tests/base_zookeeper_test.cpp 872bffb

      src/tests/base_zookeeper_test.cpp 872bffb

      third_party/Makefile.am PRE-CREATION

      third_party/Makefile.am PRE-CREATION

      Diff: https://reviews.apache.org/r/3588/diff

      Testing

      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - On 2012-02-01 00:19:15, Benjamin Hindman wrote: > third_party/Makefile.am, line 4 > < https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line4 > > > Why @SUBCONFIG_ARGS@ instead of $(SUBCONFIG_ARGS)? That would be recursive on this line (since we are defining SUBCONFIG_ARGS for make purposes but not .in substitution purposes). On 2012-02-01 00:19:15, Benjamin Hindman wrote: > src/Makefile.am, lines 22-23 > < https://reviews.apache.org/r/3588/diff/3/?file=70274#file70274line22 > > > s/move/Move and kill tab (or indentation). Done. On 2012-02-01 00:19:15, Benjamin Hindman wrote: > third_party/Makefile.am, line 2 > < https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line2 > > > Not used. Removed. On 2012-02-01 00:19:15, Benjamin Hindman wrote: > third_party/Makefile.am, line 73 > < https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line73 > > > Kill tab. Done. On 2012-02-01 00:19:15, Benjamin Hindman wrote: > third_party/Makefile.am, line 48 > < https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line48 > > > Wrap for 80 characters please (and everywhere else in this file). Done. On 2012-02-01 00:19:15, Benjamin Hindman wrote: > src/Makefile.am, line 45 > < https://reviews.apache.org/r/3588/diff/3/?file=70274#file70274line45 > > > Wrap for 80 characters please. Done. On 2012-02-01 00:19:15, Benjamin Hindman wrote: > src/Makefile.am, lines 77-78 > < https://reviews.apache.org/r/3588/diff/3/?file=70274#file70274line77 > > > I've replaced '$(top_builddir)' with '..' everywhere else in the file. You haven't, but replaced my additions of $(top_builddir) with .. Charles ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3588/#review4725 ----------------------------------------------------------- On 2012-02-01 02:25:11, Charles Reiss wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3588/ ----------------------------------------------------------- (Updated 2012-02-01 02:25:11) Review request for mesos. Summary ------- Builds third_party from tarballs instead of having us distribute the unpacked source. To make it sane to review, this patch does not include the tarballs or the removal of the original third_party directories. Everything but distribute-* should be put into tarballs for this to work. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs ----- Makefile.am d979bbb Makefile.am d979bbb configure.ac 283b49a configure.ac 283b49a src/Makefile.am ac0a209 src/Makefile.am ac0a209 src/examples/python/test-executor.in d730116 src/examples/python/test-executor.in d730116 src/examples/python/test-framework.in 0f6a6a9 src/examples/python/test-framework.in 0f6a6a9 src/python/setup.py.in 07aaa58 src/python/setup.py.in 07aaa58 src/tests/base_zookeeper_test.cpp 872bffb src/tests/base_zookeeper_test.cpp 872bffb third_party/Makefile.am PRE-CREATION third_party/Makefile.am PRE-CREATION Diff: https://reviews.apache.org/r/3588/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3588/
      -----------------------------------------------------------

      (Updated 2012-02-01 02:25:11.995218)

      Review request for mesos.

      Changes
      -------

      Also merged with current trunk.

      Summary
      -------

      Builds third_party from tarballs instead of having us distribute the unpacked source.

      To make it sane to review, this patch does not include the tarballs or the removal of the original third_party directories. Everything but distribute-* should be put into tarballs for this to work.

      This addresses bug MESOS-120.
      https://issues.apache.org/jira/browse/MESOS-120

      Diffs (updated)


      Makefile.am d979bbb
      Makefile.am d979bbb
      configure.ac 283b49a
      configure.ac 283b49a
      src/Makefile.am ac0a209
      src/Makefile.am ac0a209
      src/examples/python/test-executor.in d730116
      src/examples/python/test-executor.in d730116
      src/examples/python/test-framework.in 0f6a6a9
      src/examples/python/test-framework.in 0f6a6a9
      src/python/setup.py.in 07aaa58
      src/python/setup.py.in 07aaa58
      src/tests/base_zookeeper_test.cpp 872bffb
      src/tests/base_zookeeper_test.cpp 872bffb
      third_party/Makefile.am PRE-CREATION
      third_party/Makefile.am PRE-CREATION

      Diff: https://reviews.apache.org/r/3588/diff

      Testing
      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3588/ ----------------------------------------------------------- (Updated 2012-02-01 02:25:11.995218) Review request for mesos. Changes ------- Also merged with current trunk. Summary ------- Builds third_party from tarballs instead of having us distribute the unpacked source. To make it sane to review, this patch does not include the tarballs or the removal of the original third_party directories. Everything but distribute-* should be put into tarballs for this to work. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs (updated) Makefile.am d979bbb Makefile.am d979bbb configure.ac 283b49a configure.ac 283b49a src/Makefile.am ac0a209 src/Makefile.am ac0a209 src/examples/python/test-executor.in d730116 src/examples/python/test-executor.in d730116 src/examples/python/test-framework.in 0f6a6a9 src/examples/python/test-framework.in 0f6a6a9 src/python/setup.py.in 07aaa58 src/python/setup.py.in 07aaa58 src/tests/base_zookeeper_test.cpp 872bffb src/tests/base_zookeeper_test.cpp 872bffb third_party/Makefile.am PRE-CREATION third_party/Makefile.am PRE-CREATION Diff: https://reviews.apache.org/r/3588/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/3588/#review4947
      -----------------------------------------------------------

      Ship it!

      I pulled libprocess out of the bunch for now and made a few minor tweaks (comments, etc), but I'm committing this now!

      • Benjamin

      On 2012-02-01 02:25:11, Charles Reiss wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/3588/

      -----------------------------------------------------------

      (Updated 2012-02-01 02:25:11)

      Review request for mesos.

      Summary

      -------

      Builds third_party from tarballs instead of having us distribute the unpacked source.

      To make it sane to review, this patch does not include the tarballs or the removal of the original third_party directories. Everything but distribute-* should be put into tarballs for this to work.

      This addresses bug MESOS-120.

      https://issues.apache.org/jira/browse/MESOS-120

      Diffs

      -----

      Makefile.am d979bbb

      Makefile.am d979bbb

      configure.ac 283b49a

      configure.ac 283b49a

      src/Makefile.am ac0a209

      src/Makefile.am ac0a209

      src/examples/python/test-executor.in d730116

      src/examples/python/test-executor.in d730116

      src/examples/python/test-framework.in 0f6a6a9

      src/examples/python/test-framework.in 0f6a6a9

      src/python/setup.py.in 07aaa58

      src/python/setup.py.in 07aaa58

      src/tests/base_zookeeper_test.cpp 872bffb

      src/tests/base_zookeeper_test.cpp 872bffb

      third_party/Makefile.am PRE-CREATION

      third_party/Makefile.am PRE-CREATION

      Diff: https://reviews.apache.org/r/3588/diff

      Testing

      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3588/#review4947 ----------------------------------------------------------- Ship it! I pulled libprocess out of the bunch for now and made a few minor tweaks (comments, etc), but I'm committing this now! Benjamin On 2012-02-01 02:25:11, Charles Reiss wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3588/ ----------------------------------------------------------- (Updated 2012-02-01 02:25:11) Review request for mesos. Summary ------- Builds third_party from tarballs instead of having us distribute the unpacked source. To make it sane to review, this patch does not include the tarballs or the removal of the original third_party directories. Everything but distribute-* should be put into tarballs for this to work. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs ----- Makefile.am d979bbb Makefile.am d979bbb configure.ac 283b49a configure.ac 283b49a src/Makefile.am ac0a209 src/Makefile.am ac0a209 src/examples/python/test-executor.in d730116 src/examples/python/test-executor.in d730116 src/examples/python/test-framework.in 0f6a6a9 src/examples/python/test-framework.in 0f6a6a9 src/python/setup.py.in 07aaa58 src/python/setup.py.in 07aaa58 src/tests/base_zookeeper_test.cpp 872bffb src/tests/base_zookeeper_test.cpp 872bffb third_party/Makefile.am PRE-CREATION third_party/Makefile.am PRE-CREATION Diff: https://reviews.apache.org/r/3588/diff Testing ------- Thanks, Charles
      Hide
      Sam Whitlock added a comment -

      @AlexDegtiar and I get the following error when trying to build this in the ubuntu VM:

      Making all in .
      make[1]: Entering directory `/home/sam/dev/mesos-monitoring'
      make[1]: Nothing to be done for `all-am'.
      make[1]: Leaving directory `/home/sam/dev/mesos-monitoring'
      Making all in third_party
      make[1]: Entering directory `/home/sam/dev/mesos-monitoring/third_party'
      make all-am
      make[2]: Entering directory `/home/sam/dev/mesos-monitoring/third_party'
      make[2]: *** No rule to make target `distribute-0.6.19', needed by `all-local'. Stop.
      make[2]: Leaving directory `/home/sam/dev/mesos-monitoring/third_party'
      make[1]: *** [all] Error 2
      make[1]: Leaving directory `/home/sam/dev/mesos-monitoring/third_party'
      make: *** [all-recursive] Error 1

      It this a problem related to this commit?

      Show
      Sam Whitlock added a comment - @AlexDegtiar and I get the following error when trying to build this in the ubuntu VM: Making all in . make [1] : Entering directory `/home/sam/dev/mesos-monitoring' make [1] : Nothing to be done for `all-am'. make [1] : Leaving directory `/home/sam/dev/mesos-monitoring' Making all in third_party make [1] : Entering directory `/home/sam/dev/mesos-monitoring/third_party' make all-am make [2] : Entering directory `/home/sam/dev/mesos-monitoring/third_party' make [2] : *** No rule to make target `distribute-0.6.19', needed by `all-local'. Stop. make [2] : Leaving directory `/home/sam/dev/mesos-monitoring/third_party' make [1] : *** [all] Error 2 make [1] : Leaving directory `/home/sam/dev/mesos-monitoring/third_party' make: *** [all-recursive] Error 1 It this a problem related to this commit?
      Hide
      Sam Whitlock added a comment -

      @AlexDegtiar and I get the following error when trying to build this in the ubuntu VM:

      Making all in .
      make[1]: Entering directory `/home/sam/dev/mesos-monitoring'
      make[1]: Nothing to be done for `all-am'.
      make[1]: Leaving directory `/home/sam/dev/mesos-monitoring'
      Making all in third_party
      make[1]: Entering directory `/home/sam/dev/mesos-monitoring/third_party'
      make all-am
      make[2]: Entering directory `/home/sam/dev/mesos-monitoring/third_party'
      make[2]: *** No rule to make target `distribute-0.6.19', needed by `all-local'. Stop.
      make[2]: Leaving directory `/home/sam/dev/mesos-monitoring/third_party'
      make[1]: *** [all] Error 2
      make[1]: Leaving directory `/home/sam/dev/mesos-monitoring/third_party'
      make: *** [all-recursive] Error 1

      I was trying to build by checking out the git branch that tracks the apache remote that mirrors the svn repo.

      Show
      Sam Whitlock added a comment - @AlexDegtiar and I get the following error when trying to build this in the ubuntu VM: Making all in . make [1] : Entering directory `/home/sam/dev/mesos-monitoring' make [1] : Nothing to be done for `all-am'. make [1] : Leaving directory `/home/sam/dev/mesos-monitoring' Making all in third_party make [1] : Entering directory `/home/sam/dev/mesos-monitoring/third_party' make all-am make [2] : Entering directory `/home/sam/dev/mesos-monitoring/third_party' make [2] : *** No rule to make target `distribute-0.6.19', needed by `all-local'. Stop. make [2] : Leaving directory `/home/sam/dev/mesos-monitoring/third_party' make [1] : *** [all] Error 2 make [1] : Leaving directory `/home/sam/dev/mesos-monitoring/third_party' make: *** [all-recursive] Error 1 I was trying to build by checking out the git branch that tracks the apache remote that mirrors the svn repo.
      Hide
      Charles Reiss added a comment -

      @Sam: Your build error is related to the commit; it should be fixed by r1242493.

      Show
      Charles Reiss added a comment - @Sam: Your build error is related to the commit; it should be fixed by r1242493.
      Hide
      Benjamin Hindman added a comment -

      This should be fixed and committed. Please do a git pull.

      Show
      Benjamin Hindman added a comment - This should be fixed and committed. Please do a git pull.
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4086/
      -----------------------------------------------------------

      Review request for mesos and Benjamin Hindman.

      Summary
      -------

      This patch fixes some problems discovered through 'make distclean'.

      This addresses bug MESOS-120.
      https://issues.apache.org/jira/browse/MESOS-120

      Diffs


      src/Makefile.am a1ff40c
      third_party/Makefile.am fdfb665

      Diff: https://reviews.apache.org/r/4086/diff

      Testing
      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4086/ ----------------------------------------------------------- Review request for mesos and Benjamin Hindman. Summary ------- This patch fixes some problems discovered through 'make distclean'. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs src/Makefile.am a1ff40c third_party/Makefile.am fdfb665 Diff: https://reviews.apache.org/r/4086/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4086/#review5445
      -----------------------------------------------------------

      third_party/Makefile.am
      <https://reviews.apache.org/r/4086/#comment11848>

      When does this file not exist?

      • Benjamin

      On 2012-02-28 19:22:19, Charles Reiss wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/4086/

      -----------------------------------------------------------

      (Updated 2012-02-28 19:22:19)

      Review request for mesos and Benjamin Hindman.

      Summary

      -------

      This patch fixes some problems discovered through 'make distclean'.

      This addresses bug MESOS-120.

      https://issues.apache.org/jira/browse/MESOS-120

      Diffs

      -----

      src/Makefile.am a1ff40c

      third_party/Makefile.am fdfb665

      Diff: https://reviews.apache.org/r/4086/diff

      Testing

      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4086/#review5445 ----------------------------------------------------------- third_party/Makefile.am < https://reviews.apache.org/r/4086/#comment11848 > When does this file not exist? Benjamin On 2012-02-28 19:22:19, Charles Reiss wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4086/ ----------------------------------------------------------- (Updated 2012-02-28 19:22:19) Review request for mesos and Benjamin Hindman. Summary ------- This patch fixes some problems discovered through 'make distclean'. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs ----- src/Makefile.am a1ff40c third_party/Makefile.am fdfb665 Diff: https://reviews.apache.org/r/4086/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      On 2012-02-29 06:54:32, Benjamin Hindman wrote:

      > third_party/Makefile.am, line 113

      > <https://reviews.apache.org/r/4086/diff/1/?file=86278#file86278line113>

      >

      > When does this file not exist?

      The clean-local target can be run as part of distclean (apparently after doing the distclean on the DIST_SUBDIRS).

      • Charles

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4086/#review5445
      -----------------------------------------------------------

      On 2012-02-28 19:22:19, Charles Reiss wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/4086/

      -----------------------------------------------------------

      (Updated 2012-02-28 19:22:19)

      Review request for mesos and Benjamin Hindman.

      Summary

      -------

      This patch fixes some problems discovered through 'make distclean'.

      This addresses bug MESOS-120.

      https://issues.apache.org/jira/browse/MESOS-120

      Diffs

      -----

      src/Makefile.am a1ff40c

      third_party/Makefile.am fdfb665

      Diff: https://reviews.apache.org/r/4086/diff

      Testing

      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - On 2012-02-29 06:54:32, Benjamin Hindman wrote: > third_party/Makefile.am, line 113 > < https://reviews.apache.org/r/4086/diff/1/?file=86278#file86278line113 > > > When does this file not exist? The clean-local target can be run as part of distclean (apparently after doing the distclean on the DIST_SUBDIRS). Charles ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4086/#review5445 ----------------------------------------------------------- On 2012-02-28 19:22:19, Charles Reiss wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4086/ ----------------------------------------------------------- (Updated 2012-02-28 19:22:19) Review request for mesos and Benjamin Hindman. Summary ------- This patch fixes some problems discovered through 'make distclean'. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs ----- src/Makefile.am a1ff40c third_party/Makefile.am fdfb665 Diff: https://reviews.apache.org/r/4086/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      On 2012-02-29 06:54:32, Benjamin Hindman wrote:

      > third_party/Makefile.am, line 113

      > <https://reviews.apache.org/r/4086/diff/1/?file=86278#file86278line113>

      >

      > When does this file not exist?

      Charles Reiss wrote:

      The clean-local target can be run as part of distclean (apparently after doing the distclean on the DIST_SUBDIRS).

      Ah ha. Is the better thing to do here just add SUBDIRS = libprocess and remove the call into libprocess in the all-local target as well as the clean-local target?

      • Benjamin

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4086/#review5445
      -----------------------------------------------------------

      On 2012-02-28 19:22:19, Charles Reiss wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/4086/

      -----------------------------------------------------------

      (Updated 2012-02-28 19:22:19)

      Review request for mesos and Benjamin Hindman.

      Summary

      -------

      This patch fixes some problems discovered through 'make distclean'.

      This addresses bug MESOS-120.

      https://issues.apache.org/jira/browse/MESOS-120

      Diffs

      -----

      src/Makefile.am a1ff40c

      third_party/Makefile.am fdfb665

      Diff: https://reviews.apache.org/r/4086/diff

      Testing

      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - On 2012-02-29 06:54:32, Benjamin Hindman wrote: > third_party/Makefile.am, line 113 > < https://reviews.apache.org/r/4086/diff/1/?file=86278#file86278line113 > > > When does this file not exist? Charles Reiss wrote: The clean-local target can be run as part of distclean (apparently after doing the distclean on the DIST_SUBDIRS). Ah ha. Is the better thing to do here just add SUBDIRS = libprocess and remove the call into libprocess in the all-local target as well as the clean-local target? Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4086/#review5445 ----------------------------------------------------------- On 2012-02-28 19:22:19, Charles Reiss wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4086/ ----------------------------------------------------------- (Updated 2012-02-28 19:22:19) Review request for mesos and Benjamin Hindman. Summary ------- This patch fixes some problems discovered through 'make distclean'. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs ----- src/Makefile.am a1ff40c third_party/Makefile.am fdfb665 Diff: https://reviews.apache.org/r/4086/diff Testing ------- Thanks, Charles
      Hide
      jiraposter@reviews.apache.org added a comment -

      On 2012-02-29 06:54:32, Benjamin Hindman wrote:

      > third_party/Makefile.am, line 113

      > <https://reviews.apache.org/r/4086/diff/1/?file=86278#file86278line113>

      >

      > When does this file not exist?

      Charles Reiss wrote:

      The clean-local target can be run as part of distclean (apparently after doing the distclean on the DIST_SUBDIRS).

      Benjamin Hindman wrote:

      Ah ha. Is the better thing to do here just add SUBDIRS = libprocess and remove the call into libprocess in the all-local target as well as the clean-local target?

      FYI, making this change (and fixing a bug in the libprocess tests) I was able to run 'make distcheck'. I'll commit this unless you have any reservations.

      • Benjamin

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/4086/#review5445
      -----------------------------------------------------------

      On 2012-02-28 19:22:19, Charles Reiss wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/4086/

      -----------------------------------------------------------

      (Updated 2012-02-28 19:22:19)

      Review request for mesos and Benjamin Hindman.

      Summary

      -------

      This patch fixes some problems discovered through 'make distclean'.

      This addresses bug MESOS-120.

      https://issues.apache.org/jira/browse/MESOS-120

      Diffs

      -----

      src/Makefile.am a1ff40c

      third_party/Makefile.am fdfb665

      Diff: https://reviews.apache.org/r/4086/diff

      Testing

      -------

      Thanks,

      Charles

      Show
      jiraposter@reviews.apache.org added a comment - On 2012-02-29 06:54:32, Benjamin Hindman wrote: > third_party/Makefile.am, line 113 > < https://reviews.apache.org/r/4086/diff/1/?file=86278#file86278line113 > > > When does this file not exist? Charles Reiss wrote: The clean-local target can be run as part of distclean (apparently after doing the distclean on the DIST_SUBDIRS). Benjamin Hindman wrote: Ah ha. Is the better thing to do here just add SUBDIRS = libprocess and remove the call into libprocess in the all-local target as well as the clean-local target? FYI, making this change (and fixing a bug in the libprocess tests) I was able to run 'make distcheck'. I'll commit this unless you have any reservations. Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4086/#review5445 ----------------------------------------------------------- On 2012-02-28 19:22:19, Charles Reiss wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4086/ ----------------------------------------------------------- (Updated 2012-02-28 19:22:19) Review request for mesos and Benjamin Hindman. Summary ------- This patch fixes some problems discovered through 'make distclean'. This addresses bug MESOS-120 . https://issues.apache.org/jira/browse/MESOS-120 Diffs ----- src/Makefile.am a1ff40c third_party/Makefile.am fdfb665 Diff: https://reviews.apache.org/r/4086/diff Testing ------- Thanks, Charles
      Charles Reiss made changes -
      Status Open [ 1 ] In Progress [ 3 ]
      Hide
      Charles Reiss added a comment -

      I believe that this currently works except for the deploy scripts.

      Show
      Charles Reiss added a comment - I believe that this currently works except for the deploy scripts.
      Charles Reiss made changes -
      Status In Progress [ 3 ] Resolved [ 5 ]
      Resolution Fixed [ 1 ]
      Mark Thomas made changes -
      Workflow jira [ 12649763 ] Mesos workflow [ 12740966 ]

        People

        • Assignee:
          Charles Reiss
          Reporter:
          Benjamin Hindman
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development