Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-1057

libprocess: Add explicit to single argument constructors

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 0.19.0
    • libprocess

    Description

      Exactly like MESOS-1055, just splitting out the task for lib process into a separate issue.

      From the google style guide:
      Normally, if a constructor takes one argument, it can be used as a conversion. For instance, if you define Foo::Foo(string name) and then pass a string to a function that expects a Foo, the constructor will be called to convert the string into a Foo and will pass the Foo to your function for you. This can be convenient but is also a source of trouble when things get converted and new objects created without you meaning them to. Declaring a constructor explicit prevents it from being invoked implicitly as a conversion.
      Implicit conversions should be the exception to avoid unwanted and unexpected behaviour.

      Attachments

        Activity

          People

            bernd-mesos Bernd Mathiske
            bernd-mesos Bernd Mathiske
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 2h
                2h
                Remaining:
                Remaining Estimate - 2h
                2h
                Logged:
                Time Spent - Not Specified
                Not Specified