[MENFORCER-301] banDuplicatePomDependencyVersions does not check managementDependencies

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-M1
• Fix Version/s: 3.0.0
• Component/s: Standard Rules
• Assignee: Sylwester Lachiewicz
• Reporter: Alexander Kudrevatykh
• Created: 16/Apr/18 08:54
• Updated: 27/Jul/20 15:07
• Resolved: 27/Jul/20 14:29

Description

MENFORCER-152 added rule for ban duplicate depndencies, but dependencyManagement section does not checked correctly
code 

 if ( model.getDependencyManagement() != null ) 
{
    List<Dependency> managementDependencies = model.getDependencies();
    Map<String, Integer> duplicateManagementDependencies = validateDependencies( managementDependencies );

should be written as

if ( model.getDependencyManagement() != null ) 
{
    List<Dependency> managementDependencies = model.getDependencyManagement().getDependencies();
    Map<String, Integer> duplicateManagementDependencies = validateDependencies( managementDependencies );

and same fix should be applied to

profiles

checking code

Issue Links

• links to: GitHub Pull Request #33