[MENFORCER-101] Enforcer does not allow to restrict based on SNAPSHOT version as version comparison uses artifact.getVersion() instead of artifact.getBaseVersion()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0-beta-1
• Fix Version/s: 1.0
• Component/s: Standard Rules
• Environment: Any
• Flags: Patch
• Assignee: Unassigned
• Reporter: Prashant Bhate
• Created: 15/Jul/10 11:41
• Updated: 05/Apr/15 14:44
• Resolved: 27/Oct/10 20:40

Description

When following restriction is given to banned dependency rule, comparison fails as it compare with actual snapshot version in the repository (which includes timestamp 1.0-20100715.155142-18 ) instead of base version ( which has 1.0-SNAPSHOT )

<build>
<plugins>
<plugin>
<artifactId>maven-enforcer-plugin</artifactId>
<executions> 
<execution>
  <id>enforce-snapshot-ver</id>
  <goals>
    <goal>enforce</goal>
  </goals>
  <configuration>
    <rules>
      <bannedDependencies>
        <searchTransitive>true</searchTransitive>
        <excludes>
          <exclude>org.apache.maven.enforcer:enforcer-rules</exclude>
        </excludes>
        <includes>
          <include>org.apache.maven.enforcer:enforcer-rules:[1.0-beta-2-SNAPSHOT]</include>
        </includes>
      </bannedDependencies>
    </rules>
    <fail>true</fail>
  </configuration>
</execution>
</executions>
</plugin>
</plugins>
..
..
..
<dependencies>
<dependency>
  <groupId>org.apache.maven.enforcer</groupId>
  <artifactId>enforcer-rules</artifactId>
  <version>1.0-beta-2-SNAPSHOT</version>
</dependency>
</dependencies>

See code snippet below

BannedDependencies.java

try
{
 result = AbstractVersionEnforcer.containsVersion( 
            VersionRange.createFromVersionSpec( pattern[2] ),
            new DefaultArtifactVersion(  artifact.getVersion() ) 
          );
}
catch ( InvalidVersionSpecificationException e )
{
throw new EnforcerRuleException( "Invalid Version Range: ", e );
}

replace

 new DefaultArtifactVersion(  artifact.getVersion() ) 

with

 new DefaultArtifactVersion(  artifact.getBaseVersion() )

will solve this issue

Issue Links

• relates to: MENFORCER-94 Review evaluation of version ranges with regard to inclusion of snapshots