Maven Eclipse Plugin
  1. Maven Eclipse Plugin
  2. MECLIPSE-449

Facet Generation generates duplicate entries - breaks RAD/RSA support

    Details

    • Type: Bug Bug
    • Status: Reopened
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.5.1
    • Fix Version/s: None
    • Component/s: WTP support
    • Labels:
      None
    • Environment:
      WinXP, IBM RSA V7.0.0.6 (Eclipse 3.2.2)

      Description

      Using V2.5.1 of the maven-eclipse-plugin, I have some issues in getting the generated artifacts being correct.

      Take this section of the POM:

      <additionalProjectFacets>
      <jst.java>5.0</jst.java>
      <jst.ejb>2.1</jst.ejb>
      <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
      </additionalProjectFacets>

      Generates this:

      <faceted-project>
      <fixed facet="jst.java"/>
      <fixed facet="jst.utility"/>
      <installed facet="jst.utility" version="1.0"/>
      <installed facet="jst.java" version="5.0"/>
      <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
      <installed facet="jst.ejb" version="2.1"/>
      <installed facet="jst.java" version="5.0"/>
      </faceted-project>

      You'll see that the jst.java facet is in there twice.

      Removing the facet from the list:

      <additionalProjectFacets>
      <jst.ejb>2.1</jst.ejb>
      <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
      </additionalProjectFacets>

      Generates this:

      <faceted-project>
      <fixed facet="jst.java"/>
      <fixed facet="jst.utility"/>
      <installed facet="jst.utility" version="1.0"/>
      <installed facet="jst.java" version="5.0"/>
      <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
      <installed facet="jst.ejb" version="2.1"/>
      </faceted-project>

      Which is a little more correct.

      I consider this a bug, as the facets (by their very definition) are unique and should not be repeated.

      Additionally, when compared to a RSA (V7) generated one, it is missing the standard XML header:

      <?xml version="1.0" encoding="UTF-8"?>

      Also, where does the jst.utility facet come from?

      It's inclusion is getting in the way of RSA recognising it as a true J2EE component project (the EJB Deployment descriptor tree element does not display in the Project Explorer view in the J2EE Perspective).

      This is the complete RSA generated one, for reference:

      <?xml version="1.0" encoding="UTF-8"?>
      <faceted-project>
      <runtime name="WebSphere Application Server v6.1"/>
      <fixed facet="jst.ejb"/>
      <fixed facet="jst.java"/>
      <installed facet="jst.ejb" version="2.1"/>
      <installed facet="jst.java" version="5.0"/>
      <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
      </faceted-project>

      (Which raises another question, how do we specify the runtime items and if something is fixed or not?)

      However, to get it to be correctly recognised, all we need is this:

      <faceted-project>
      <fixed facet="jst.java"/>
      <installed facet="jst.java" version="5.0"/>
      <installed facet="jst.ejb" version="2.1"/>
      <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
      </faceted-project>

      1. MECLIPSE-449.patch
        22 kB
        Daniel Rohe
      2. sample-error.zip
        3 kB
        Diego Gomes
      3. sample-noerror.zip
        3 kB
        Diego Gomes

        Activity

        Chris Graham created issue -
        Arnaud HERITIER made changes -
        Field Original Value New Value
        Fix Version/s 2.8 [ 14813 ]
        Daniel Rohe made changes -
        Attachment MECLIPSE-449.patch [ 45526 ]
        Benjamin Bentmann made changes -
        Fix Version/s 2.8 [ 14813 ]
        Fix Version/s 2.9 [ 16240 ]
        Diego Gomes made changes -
        Attachment sample-noerror.zip [ 50862 ]
        Attachment sample-error.zip [ 50861 ]
        Barrie Treloar made changes -
        Fix Version/s 2.9 [ 16240 ]
        Michael Osipov made changes -
        Resolution Won't Fix [ 2 ]
        Status Open [ 1 ] Closed [ 6 ]
        Michael Osipov made changes -
        Status Closed [ 6 ] Reopened [ 4 ]
        Resolution Won't Fix [ 2 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 10:00:37 UTC 2015 [ 1428228037919 ]
        Mark Thomas made changes -
        Workflow jira [ 12720846 ] Default workflow, editable Closed status [ 12750490 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 23:47:18 UTC 2015 [ 1428277638729 ]
        Mark Thomas made changes -
        Workflow jira [ 12958504 ] Default workflow, editable Closed status [ 12995386 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Chris Graham
          • Votes:
            4 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:

              Development