[MECLIPSE-206] IdeUtils.toRelativeAndFixSeparator broken on Windows

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.6
• Component/s: Core : Workspace settings
• Environment: Windows XP
• Assignee: Barrie Treloar
• Reporter: Barrie Treloar
• Created: 10/Dec/06 18:53
• Updated: 16/Sep/08 23:15
• Resolved: 16/Sep/08 23:15

Description

See http://www.nabble.com/forum/ViewPost.jtp?post=7753417&framed=y&skin=177

The problem is that IdeUtils.toRelativeAndFixSeparator attempts to canonicalise relative paths.
This will cause the result to be based on the current directory of the processor and not the project basedir as intended.
This causes the build to fail with canonicalisation errors.

I have supplied a patch against r485327 which includes extra test cases and all test cases pass.

I have also:

• removed the project
• removed use of assertTrue and converted to assertEquals (tests were succeeding when they should not have because the check was on the trailing path not the entire path)
• removed MavenProject from extractResourceDirs (it was never used)

Some other comments:
baseDir and projectBaseDir seem to be used but I can not see any use cases where these two are not the same value. Shouldn't the pom file always be located at the top of the eclipse project workspace? The similar names and mostly the same value caused me trouble in understanding the system. If they could get removed it would make things easier.