Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.6
    • Component/s: AJDT support
    • Labels:
      None
    • Flags:
      Patch

      Description

      Please add support for the AJDT plugin.

      I have modified the eclipse plugin for our site with the needed changes. I have attached the modifications that I made for someone to look at and incorporate into the plugin.

      1. ajdt.patch
        23 kB
        Carlos Sanchez
      2. maven-eclipse-plugin.zip
        122 kB
        Eric Berry
      3. maven-eclipse-plugin.zip
        14 kB
        Eric Berry

        Issue Links

          Activity

          Eric Berry created issue -
          Hide
          Carlos Sanchez added a comment -

          Previous attachment in diff format

          Show
          Carlos Sanchez added a comment - Previous attachment in diff format
          Carlos Sanchez made changes -
          Field Original Value New Value
          Attachment ajdt.patch [ 26256 ]
          Arnaud HERITIER made changes -
          Patch Submitted [Yes]
          Arnaud HERITIER made changes -
          Component/s AJDT support [ 13074 ]
          Frank Stolle made changes -
          Link This issue relates to MECLIPSE-313 [ MECLIPSE-313 ]
          Hide
          Eric Berry added a comment - - edited

          This has been updated for maven-eclipse-plugin 2.5.1 and also ajdt version 1.5.3. I have also included tests and updates to the site build to show how to use it.

          Hopefully one of the commiters will be willing to look at this and incorporate it.

          Show
          Eric Berry added a comment - - edited This has been updated for maven-eclipse-plugin 2.5.1 and also ajdt version 1.5.3. I have also included tests and updates to the site build to show how to use it. Hopefully one of the commiters will be willing to look at this and incorporate it.
          Eric Berry made changes -
          Attachment maven-eclipse-plugin.zip [ 34827 ]
          Hide
          Eric Berry added a comment -

          Look at the 122kb maven-eclipse-plugin.zip.

          Show
          Eric Berry added a comment - Look at the 122kb maven-eclipse-plugin.zip.
          Eric Berry made changes -
          Link This issue is duplicated by MECLIPSE-270 [ MECLIPSE-270 ]
          David J. M. Karlsen made changes -
          Link This issue is duplicated by MOJO-839 [ MOJO-839 ]
          Arnaud HERITIER made changes -
          Assignee Arnaud Heritier [ aheritier ]
          Arnaud HERITIER made changes -
          Fix Version/s 2.5.2 [ 14163 ]
          Arnaud HERITIER made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Arnaud HERITIER added a comment -

          Fixed and snapshot 2.6-20080902.232029-1 deployed. If you can test it ....

          Show
          Arnaud HERITIER added a comment - Fixed and snapshot 2.6-20080902.232029-1 deployed. If you can test it ....
          Arnaud HERITIER made changes -
          Status In Progress [ 3 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Hide
          Eric Berry added a comment -

          Tested. It works as expected. Thanks.

          Show
          Eric Berry added a comment - Tested. It works as expected. Thanks.
          Hide
          David J. M. Karlsen added a comment -

          Is the site staged anywhere (to be able to see documentation of new parameters)

          Show
          David J. M. Karlsen added a comment - Is the site staged anywhere (to be able to see documentation of new parameters)
          Hide
          Arnaud HERITIER added a comment -
          Show
          Arnaud HERITIER added a comment - It will be in few hours here : http://maven.apache.org/plugins/maven-eclipse-plugin-2.6-SNAPSHOT/
          Alexander Hachmann made changes -
          Link This issue is depended upon by MECLIPSE-544 [ MECLIPSE-544 ]
          Hide
          Alexander Hachmann added a comment -

          I can understand the wish for a AJDT-Plugin support, but I cannot understand
          why this must have such an impact on projects that do not use that plugin.

          As we do not use that plugin we now are having the problem that our projects
          do not compile for the reason of the missing jars :-/

          In my eyes this AJDT-Plugin Feature MUST be implemented in a more generic way.
          Read the eclipse configurations whether that plugin is installed or something else.
          But do not force other Projects to use the AJDT Plugin, just because the are workin
          with AOP!!!!

          Show
          Alexander Hachmann added a comment - I can understand the wish for a AJDT-Plugin support, but I cannot understand why this must have such an impact on projects that do not use that plugin. As we do not use that plugin we now are having the problem that our projects do not compile for the reason of the missing jars :-/ In my eyes this AJDT-Plugin Feature MUST be implemented in a more generic way. Read the eclipse configurations whether that plugin is installed or something else. But do not force other Projects to use the AJDT Plugin, just because the are workin with AOP!!!!
          Hide
          Arnaud HERITIER added a comment -

          Please open an new issue if this one creates a problem for you. A 2.7 is already on rails.

          Show
          Arnaud HERITIER added a comment - Please open an new issue if this one creates a problem for you. A 2.7 is already on rails.
          Hide
          Eric Berry added a comment - - edited

          Alexander, In the configuration of the eclipse plugin add <ajdtVersion>none</ajdtVersion>. This should fix the problem.

          There is hidden documentation here http://maven.apache.org/plugins/maven-eclipse-plugin/examples/ajdt-projects.html that describes how to use the ajdt plugin.

          Show
          Eric Berry added a comment - - edited Alexander, In the configuration of the eclipse plugin add <ajdtVersion>none</ajdtVersion>. This should fix the problem. There is hidden documentation here http://maven.apache.org/plugins/maven-eclipse-plugin/examples/ajdt-projects.html that describes how to use the ajdt plugin.
          Tan Quach made changes -
          Link This issue is related to MECLIPSE-547 [ MECLIPSE-547 ]
          Hide
          Tan Quach added a comment -

          I agree with Alexander, and I've created a new issue: http://jira.codehaus.org/browse/MECLIPSE-547

          Show
          Tan Quach added a comment - I agree with Alexander, and I've created a new issue: http://jira.codehaus.org/browse/MECLIPSE-547
          Hide
          Eirik Larsen added a comment -

          According to the comments on MECLIPSE-270, this jira task replaces/duplicates that task. MECLIPSE-270 is about adding attributes to classpathentries in .classpath.

          Can someone please elaborate how this can be accomplished in the pom.xml? This feature lacks documentation on the project website.

          Regards

          Show
          Eirik Larsen added a comment - According to the comments on MECLIPSE-270 , this jira task replaces/duplicates that task. MECLIPSE-270 is about adding attributes to classpathentries in .classpath. Can someone please elaborate how this can be accomplished in the pom.xml? This feature lacks documentation on the project website. Regards
          Hide
          Arnaud HERITIER added a comment -

          The documentation about ajdt is here : http://maven.apache.org/plugins/maven-eclipse-plugin/examples/ajdt-projects.html
          You can find several exemples here : http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-eclipse-plugin/src/test/resources/projects/
          If some docs are missing, do not hesitate to open an issue. We'll try to improve it.
          We know there are many lacks in it.

          Show
          Arnaud HERITIER added a comment - The documentation about ajdt is here : http://maven.apache.org/plugins/maven-eclipse-plugin/examples/ajdt-projects.html You can find several exemples here : http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-eclipse-plugin/src/test/resources/projects/ If some docs are missing, do not hesitate to open an issue. We'll try to improve it. We know there are many lacks in it.
          Hide
          Eirik Larsen added a comment -

          Arnaud: thanks for the link.

          After plundering around, I found that adding wtp version 2.0 to the pom automatically added the required attributes to the classpathentries like this:

          <classpathentry kind="var" path="M2_REPO/log4j/log4j/1.2.15/log4j-1.2.15.jar" sourcepath="M2_REPO/log4j/log4j/1.2.15/log4j-1.2.15-sources.jar">
          <attributes>
          <attribute value="/WEB-INF/lib" name="org.eclipse.jst.component.dependency"/>
          </attributes>
          </classpathentry>

          A nice feature was that the attribute was only added if the maven dependency scope was compile or runtime. Small question though: If the scope is provided, the maven eclipse plugin doesn't add any attribute to the corresponding classpathentry. The wtp plugin for eclipse seems to support the following attribute for entries that are not to be deployed:

          "org.eclipse.jst.component.nondependency"

          Maybe you should add this for scope provided? Just a thought..

          Thanks again!

          Show
          Eirik Larsen added a comment - Arnaud: thanks for the link. After plundering around, I found that adding wtp version 2.0 to the pom automatically added the required attributes to the classpathentries like this: <classpathentry kind="var" path="M2_REPO/log4j/log4j/1.2.15/log4j-1.2.15.jar" sourcepath="M2_REPO/log4j/log4j/1.2.15/log4j-1.2.15-sources.jar"> <attributes> <attribute value="/WEB-INF/lib" name="org.eclipse.jst.component.dependency"/> </attributes> </classpathentry> A nice feature was that the attribute was only added if the maven dependency scope was compile or runtime. Small question though: If the scope is provided, the maven eclipse plugin doesn't add any attribute to the corresponding classpathentry. The wtp plugin for eclipse seems to support the following attribute for entries that are not to be deployed: "org.eclipse.jst.component.nondependency" Maybe you should add this for scope provided? Just a thought.. Thanks again!
          Mark Thomas made changes -
          Project Import Sun Apr 05 10:00:37 UTC 2015 [ 1428228037919 ]
          Mark Thomas made changes -
          Workflow jira [ 12720614 ] Default workflow, editable Closed status [ 12750842 ]
          Mark Thomas made changes -
          Patch attached Yes [ 10860 ]
          Flags Patch [ 10430 ]
          Mark Thomas made changes -
          Patch Submitted Yes [ 10763 ]
          Mark Thomas made changes -
          Project Import Sun Apr 05 23:47:18 UTC 2015 [ 1428277638729 ]
          Mark Thomas made changes -
          Workflow jira [ 12958051 ] Default workflow, editable Closed status [ 12994881 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open In Progress In Progress
          641d 22h 46m 1 Arnaud HERITIER 02/Sep/08 13:18
          In Progress In Progress Closed Closed
          6h 4m 1 Arnaud HERITIER 02/Sep/08 19:22

            People

            • Assignee:
              Arnaud HERITIER
              Reporter:
              Eric Berry
            • Votes:
              10 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development