[MDEP-545] Several classes create mixed-style line endings

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.10
• Fix Version/s: 3.1.2
• Labels: up-for-grabs
• Assignee: Michael Osipov
• Reporter: Michael Osipov
• Created: 09/Dec/16 13:11
• Updated: 21/Mar/19 14:59
• Resolved: 21/Mar/19 14:28

Description

See:

$ grep -r '\\n' src
src/it/projects/tree/verify.bsh:actual = actual.replaceAll( "[\n\r]+", "\n" );
src/it/projects/tree/verify.bsh:expected = expected.replaceAll( "[\n\r]+", "\n" );
src/it/projects/tree-includes/verify.bsh:actual = actual.replaceAll( "[\n\r]+", "\n" );
src/it/projects/tree-includes/verify.bsh:expected = expected.replaceAll( "[\n\r]+", "\n" );
src/it/projects/tree-verbose/verify.bsh:actual = actual.replaceAll( "[\n\r]+", "\n" );
src/it/projects/tree-verbose/verify.bsh:expected = expected.replaceAll( "[\n\r]+", "\n" );
src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java:                "Error unpacking file: " + file + " to: " + location + "\r\n" + e.toString(), e );
src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java:            getLog().info( "\n" + out.getBuffer() );
src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java:                   .append( "\n" );
src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java:            getLog().info( "\n" + buf );
src/main/java/org/apache/maven/plugins/dependency/analyze/AnalyzeDuplicateMojo.java:                sb.append( "List of duplicate dependencies defined in <dependencies/> in your pom.xml:\n" );
src/main/java/org/apache/maven/plugins/dependency/analyze/AnalyzeDuplicateMojo.java:                        sb.append( "\n" );
src/main/java/org/apache/maven/plugins/dependency/analyze/AnalyzeDuplicateMojo.java:                    sb.append( "\n" );
src/main/java/org/apache/maven/plugins/dependency/analyze/AnalyzeDuplicateMojo.java:                sb.append( "List of duplicate dependencies defined in <dependencyManagement/> in your pom.xml:\n" );
src/main/java/org/apache/maven/plugins/dependency/analyze/AnalyzeDuplicateMojo.java:                        sb.append( "\n" );
src/main/java/org/apache/maven/plugins/dependency/fromDependencies/BuildClasspathMojo.java:            getLog().info( "Dependencies classpath:\n" + cpString );
src/main/java/org/apache/maven/plugins/dependency/PurgeLocalRepositoryMojo.java:            StringBuffer message = new StringBuffer( "required artifacts missing:\n" );
src/main/java/org/apache/maven/plugins/dependency/PurgeLocalRepositoryMojo.java:                message.append( "  " ).append( missingArtifact.getId() ).append( '\n' );
src/main/java/org/apache/maven/plugins/dependency/PurgeLocalRepositoryMojo.java:            message.append( "\nfor the artifact:" );
src/main/java/org/apache/maven/plugins/dependency/resolvers/ResolvePluginsMojo.java:                    outputWriter.write( "\n" );
src/main/java/org/apache/maven/plugins/dependency/resolvers/ResolvePluginsMojo.java:                            outputWriter.write( "\n" );
src/main/java/org/apache/maven/plugins/dependency/tree/DOTDependencyNodeVisitor.java:            writer.write( "digraph \"" + node.toNodeString() + "\" { \n" );
src/main/java/org/apache/maven/plugins/dependency/tree/GraphmlDependencyNodeVisitor.java:            + "http://graphml.graphdrawing.org/xmlns/1.0/graphml.xsd\">\n"
src/main/java/org/apache/maven/plugins/dependency/tree/GraphmlDependencyNodeVisitor.java:            + "  <key for=\"node\" id=\"d0\" yfiles.type=\"nodegraphics\"/> \n"
src/main/java/org/apache/maven/plugins/dependency/tree/GraphmlDependencyNodeVisitor.java:            + "  <key for=\"edge\" id=\"d1\" yfiles.type=\"edgegraphics\"/> \n"
src/main/java/org/apache/maven/plugins/dependency/tree/GraphmlDependencyNodeVisitor.java:            + "<graph id=\"dependencies\" edgedefault=\"directed\">\n";
src/main/java/org/apache/maven/plugins/dependency/utils/DependencyStatusSets.java:        sb.append( "\n" );
src/main/java/org/apache/maven/plugins/dependency/utils/DependencyStatusSets.java:        sb.append( "The following files have been resolved:\n" );
src/main/java/org/apache/maven/plugins/dependency/utils/DependencyStatusSets.java:            sb.append( "   none\n" );
src/main/java/org/apache/maven/plugins/dependency/utils/DependencyStatusSets.java:            sb.append( "\n" );
src/main/java/org/apache/maven/plugins/dependency/utils/DependencyStatusSets.java:            sb.append( "The following files were skipped:\n" );
src/main/java/org/apache/maven/plugins/dependency/utils/DependencyStatusSets.java:            sb.append( "\n" );
src/main/java/org/apache/maven/plugins/dependency/utils/DependencyStatusSets.java:            sb.append( "The following files have NOT been resolved:\n" );
src/main/java/org/apache/maven/plugins/dependency/utils/DependencyStatusSets.java:        sb.append( "\n" );
src/main/java/org/apache/maven/plugins/dependency/utils/DependencyStatusSets.java:                + "\n" );
src/test/java/org/apache/maven/plugins/dependency/AbstractDependencyMojoTestCase.java:                fail( "Trying to remove directory:" + testDir + "\r\n" + e.toString() );
src/test/java/org/apache/maven/plugins/dependency/analyze/TestAnalyzeDuplicateMojo.java:            System.err.println( "[error] " + content.toString() + "\n\n" + sWriter.toString() );
src/test/java/org/apache/maven/plugins/dependency/analyze/TestAnalyzeDuplicateMojo.java:            sb.append("[").append(prefix).append("] ").append(content.toString()).append( "\n" );
src/test/java/org/apache/maven/plugins/dependency/analyze/TestAnalyzeDuplicateMojo.java:            sb.append("[").append(prefix).append("] ").append(sWriter.toString()).append( "\n" );
src/test/java/org/apache/maven/plugins/dependency/analyze/TestAnalyzeDuplicateMojo.java:            sb.append("[").append(prefix).append("] ").append(content.toString()).append( "\n\n" )
src/test/java/org/apache/maven/plugins/dependency/analyze/TestAnalyzeDuplicateMojo.java:              .append( sWriter.toString() ).append( "\n" );
src/test/java/org/apache/maven/plugins/dependency/TestSkip.java:            System.err.println( "[error] " + content.toString() + "\n\n" + sWriter.toString() );
src/test/java/org/apache/maven/plugins/dependency/TestSkip.java:            sb.append("[").append(prefix).append("] ").append(content.toString()).append( "\n" );
src/test/java/org/apache/maven/plugins/dependency/TestSkip.java:            sb.append("[").append(prefix).append("] ").append(sWriter.toString()).append( "\n" );
src/test/java/org/apache/maven/plugins/dependency/TestSkip.java:            sb.append("[").append(prefix).append("] ").append(content.toString()).append( "\n\n" )
src/test/java/org/apache/maven/plugins/dependency/TestSkip.java:                .append( sWriter.toString() ).append( "\n" );
src/test/java/org/apache/maven/plugins/dependency/utils/TestDependencyUtil.java:        tokens = DependencyUtil.tokenizer( " \r\n a, \t \n \r b \t \n \r" );

They all should use the line ending of the underlying platform.

Issue Links

• links to: GitHub Pull Request #10