Details
-
Improvement
-
Status: Closed
-
Trivial
-
Resolution: Fixed
-
2.1
-
None
-
None
-
Patch
Description
As this method is the only abstract method, it's a pity it's the only one that's undocumented . Mainly, it's difficult to know without digging into/reading all the code if the filtering is going keep what's returned, or the contrary.
Note that org.apache.maven.shared.artifact.filter.collection.ArtifactsFilter.class is also undocumented. Naming let developer have an idea of it should do, but it'd be clearer with some javadoc .
Cheers
PS : I'm attaching a proposed patch.