Uploaded image for project: 'Maven Dependency Plugin'
  1. Maven Dependency Plugin
  2. MDEP-285

Document abstract method org.apache.maven.plugin.dependency.AbstractDependencyFilterMojo.getMarkedArtifactFilter()

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.6
    • Component/s: None
    • Labels:
      None
    • Flags:
      Patch

      Description

      As this method is the only abstract method, it's a pity it's the only one that's undocumented . Mainly, it's difficult to know without digging into/reading all the code if the filtering is going keep what's returned, or the contrary.

      Note that org.apache.maven.shared.artifact.filter.collection.ArtifactsFilter.class is also undocumented. Naming let developer have an idea of it should do, but it'd be clearer with some javadoc .

      Cheers
      PS : I'm attaching a proposed patch.

        Attachments

          Activity

            People

            • Assignee:
              hboutemy Herve Boutemy
              Reporter:
              mathus.b@mipih.fr Baptiste MATHUS
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: