[MCHECKSTYLE-341] Introduce an expectedViolation flag

• Type: New Feature
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 2.17
• Component/s: checkstyle:check
• Assignee: Robert Scholte
• Reporter: Tibo
• Created: 28/Sep/17 02:06
• Updated: 16/Jan/19 21:14
• Resolved: 16/Jan/19 21:14

Description

We are trying to fix our tech debt step by step using the maxAllowedViolation flag and reducing the number slowly.
We have 400+ maven module in our project and developer never update this flag, So basically when someone is fixing checkstyle error without updating the flag, it leaves room for another developer to introduce new errors...

I would like an expectedViolation flag just to force people who are fixing issues to also update the count... It could be called "expectedViolation". The difference with the maxAllowedViolation flag is that this one would also fail when the number of actual violation is less than the "expectedViolation" flag.

I believe the maxAllowedViolation should have been an expectedViolation from the start. I don't believe anyone wants to leave room for violation, you just want, for an existing project, to explicitly specify the current number of violation and disallow through pull request the number to go up.

Issue Links

• is related to: MCHECKSTYLE-113 Set the number of accepted violations for checkstyle:check