Maven Changes Plugin
  1. Maven Changes Plugin
  2. MCHANGES-203

Use the POMs issueManagement.system when selecting the system to use

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.4
    • Component/s: changes.xml
    • Labels:
      None

      Description

      We are defining the changes plugin in a corporate pom. We want to specify the url-templates there via issueLinkTemplatePerSystem.

      Unfortunately for the selection of the system the poms issueTracking information seems not to be used so every project has to define the plugin and set the issueLinkTemplatePerSystem (or provide a system-attribut on every action).

      Are there any reasons for not using poms project.issueTracking.system as default?

        Activity

        Michael Wenig created issue -
        Hide
        Dennis Lundberg added a comment -

        I don't follow what it is you want to do. Can you provide us with some examples?

        Show
        Dennis Lundberg added a comment - I don't follow what it is you want to do. Can you provide us with some examples?
        Hide
        Michael Wenig added a comment -

        We want to achieve that the several projects does not need to configure the changes plugin for themselves and provide a central configuration which is used when a changes.xml is present. That is working at the moment with the exception of the links to the issue system.

        In our central pom:

        <plugin>
        <maven-changes-plugin>
        <configuration>
        <issueLinkTemplatePerSystem>
        <jira>%URL%/%ISSUE%</jira>
        <bugzilla>%URL%/show_bug.cgi?id=%ISSUE%</bugzilla>
        <....>
        </issueLinkTemplatePerSystem>

        in the project A pom:
        <issueManagement>
        <type>jira</type>
        <url>...</url>
        </issueManagement>
        [no configuration of changes plugin]

        in the project B pom:
        <issueManagement>
        <type>bugzilla</type>
        <url>...</url>
        </issueManagement>
        [no configuration of changes plugin]

        When generating the changes report the plugin should choose the template according to the issueManagement.type if it is not specified at the action.
        Currently it uses everytime the 'default' (as there is normally no system attribute at the actions) which leads either to nonsense urls or the need to configure the plugin in every project:

        projectA:
        <plugin>
        <maven-changes-plugin>
        <configuration>
        <issueLinkTemplate>%URL%/%ISSUE%</issueLinkTemplate>

        projectB:
        <plugin>
        <maven-changes-plugin>
        <configuration>
        <issueLinkTemplate>%URL%/show_bug.cgi?id=%ISSUE%</issueLinkTemplate>

        I hope the pain is clear now

        Show
        Michael Wenig added a comment - We want to achieve that the several projects does not need to configure the changes plugin for themselves and provide a central configuration which is used when a changes.xml is present. That is working at the moment with the exception of the links to the issue system. In our central pom: <plugin> <maven-changes-plugin> <configuration> <issueLinkTemplatePerSystem> <jira>%URL%/%ISSUE%</jira> <bugzilla>%URL%/show_bug.cgi?id=%ISSUE%</bugzilla> <....> </issueLinkTemplatePerSystem> in the project A pom: <issueManagement> <type>jira</type> <url>...</url> </issueManagement> [no configuration of changes plugin] in the project B pom: <issueManagement> <type>bugzilla</type> <url>...</url> </issueManagement> [no configuration of changes plugin] When generating the changes report the plugin should choose the template according to the issueManagement.type if it is not specified at the action. Currently it uses everytime the 'default' (as there is normally no system attribute at the actions) which leads either to nonsense urls or the need to configure the plugin in every project: projectA: <plugin> <maven-changes-plugin> <configuration> <issueLinkTemplate>%URL%/%ISSUE%</issueLinkTemplate> projectB: <plugin> <maven-changes-plugin> <configuration> <issueLinkTemplate>%URL%/show_bug.cgi?id=%ISSUE%</issueLinkTemplate> I hope the pain is clear now
        Hide
        Dennis Lundberg added a comment -

        Thanks for that explanation. Now I see what you mean.

        Show
        Dennis Lundberg added a comment - Thanks for that explanation. Now I see what you mean.
        Dennis Lundberg made changes -
        Field Original Value New Value
        Summary Use poms issueTracking.system to select the system to use Use the POMs issueManagement.type when selecting the system to use
        Dennis Lundberg made changes -
        Assignee Dennis Lundberg [ dennislundberg ]
        Summary Use the POMs issueManagement.type when selecting the system to use Use the POMs issueManagement.system when selecting the system to use
        Hide
        Dennis Lundberg added a comment -

        Fixed in r1054461.

        The way this has been implemented may unfortunately mean that some users will need to reconfigure the plugin if they upgrade. This is because we still have to carry along some backward compatibility luggage. I have added instructions for this on the usage page. However the changes I've will make the configuration much easier to understand than before.

        Show
        Dennis Lundberg added a comment - Fixed in r1054461 . The way this has been implemented may unfortunately mean that some users will need to reconfigure the plugin if they upgrade. This is because we still have to carry along some backward compatibility luggage. I have added instructions for this on the usage page. However the changes I've will make the configuration much easier to understand than before.
        Dennis Lundberg made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Fix Version/s 2.4 [ 16043 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 09:14:45 UTC 2015 [ 1428225285377 ]
        Mark Thomas made changes -
        Workflow jira [ 12718037 ] Default workflow, editable Closed status [ 12749335 ]
        Mark Thomas made changes -
        Project Import Sun Apr 05 22:40:15 UTC 2015 [ 1428273615853 ]
        Mark Thomas made changes -
        Workflow jira [ 12955606 ] Default workflow, editable Closed status [ 12992987 ]
        Mark Thomas made changes -
        Assignee dennislundberg [ dennislundberg ] Dennis Lundberg [ dennisl@apache.org ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        202d 4h 35m 1 Dennis Lundberg 02/Jan/11 13:01

          People

          • Assignee:
            Dennis Lundberg
            Reporter:
            Michael Wenig
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development