[MCHANGES-186] Issue links for JIRA are broken when using the %URL% token

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2
• Fix Version/s: 2.3
• Component/s: changes.xml
• Assignee: Dennis Lundberg
• Reporter: Dennis Lundberg
• Created: 24/Nov/09 09:17
• Updated: 08/Apr/15 08:02
• Resolved: 26/Nov/09 07:59

Description

The fix for MCHANGES-166 included a small change that broke this. See http://jira.codehaus.org/browse/MCHANGES-166?focusedCommentId=184918&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_184918

The private method parseIssueLink(...) should remove only the trailing slash from the URL if one exists. This prevents cases where we miss to give a trailing slash in the issueManagement.url.

This part of the patch should not have been committed. The documentation for the issueLinkTemplatePerSystem parameter states:

%URL%: this is computed by getting the <issueManagement>/<url> value from the POM, and removing the last '/' and everything that comes after it.

After the patch this is no longer true. This breaks issue links to JIRA if you have a configuration like this:

  <issueManagement>
    <system>JIRA</system>
    <url>http://jira.mycompany.com/browse/PRODUCT</url>
  </issueManagement>

  <reporting>
    <plugins>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-changes-plugin</artifactId>
        <version>2.2</version>
        <configuration>
          <issueLinkTemplatePerSystem>
            <default>%URL%/%ISSUE%</default>
          </issueLinkTemplatePerSystem>
        </configuration>
      </plugin>
    </plugins>
  </reporting>