Uploaded image for project: 'Commons Math'
  1. Commons Math
  2. MATH-822

Unnecessary Parameter in EigenDecomposition?

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1
    • Labels:
      None

      Description

      I am still new to the Commons Math code base, so I am sorry if this is a dumb question. I am browsing the code for EigenDecomposition, and both of its constructors have an unused parameter called splitTolerance. The comments indicate that this is for backward compatibility.

      Would it be acceptable for me to simply include a one-parameter constructor that calls the two-parameter one, so backward compatibility is preserved and client code no longer needs to provide a pointless double?

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jbcksfrt Jared Becksfort
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 48h
                48h
                Remaining:
                Remaining Estimate - 48h
                48h
                Logged:
                Time Spent - Not Specified
                Not Specified