Commons Math
  1. Commons Math
  2. MATH-768

org.apache.commons.math3.analysis.solvers.LaguerreSolver.ComplexSolver is private

    Details

    • Type: Wish Wish
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.1
    • Labels:
      None

      Description

      We used LaguerreSolver.solveAll() in version 2.1, but we never upgraded to 2.2. As such, we didn't notice that it was deprecated in that release.

      Now that 3.0 is out, we want to upgrade, but that method has been completely removed.

      Interestingly, the logic is still there in the library in an inner class: org.apache.commons.math3.analysis.solvers.LaguerreSolver.ComplexSolver. Unfortunately for us, though, ComplexSolver is now private. So, for us as users, we've lost access to a useful algorithm that is still in the library.

      Please re-enable access to this useful algorithm that proves complex roots of polynomial formulae. The simplest approach might be to make LaguerreSolver.ComplexSolver public, but perhaps another approach would be considered better design.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        127d 16h 20m 1 Gilles 15/Jul/12 21:53
        Resolved Resolved Closed Closed
        231d 22h 1 Thomas Neidhart 04/Mar/13 18:53
        Thomas Neidhart made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Gilles made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Gilles added a comment -

        Methods "solveComplex" and "solveAllComplex" have been added to the public API in revision 1361793.

        Show
        Gilles added a comment - Methods "solveComplex" and "solveAllComplex" have been added to the public API in revision 1361793.
        Gilles made changes -
        Field Original Value New Value
        Issue Type Bug [ 1 ] Wish [ 5 ]
        Fix Version/s 3.1 [ 12317576 ]
        Priority Major [ 3 ] Minor [ 4 ]
        Hide
        Gilles added a comment -

        As I've explained on the "user" ML, the removal was intentional.

        It would be helpful if you would open a discussion on the "dev" ML, that would lead to adopting a design for the complex solvers (such as what should be the API, how to name the interface and classes, in which those should belong, ...)

        Show
        Gilles added a comment - As I've explained on the "user" ML, the removal was intentional. It would be helpful if you would open a discussion on the "dev" ML, that would lead to adopting a design for the complex solvers (such as what should be the API, how to name the interface and classes, in which those should belong, ...)
        Lance Finney created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Lance Finney
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development