Commons Math
  1. Commons Math
  2. MATH-760

DescriptiveStatistics.windowSize has a getter and setter, but is protected, so subclasses can bypass the validation check in the setter

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 4.0
    • Labels:
      None

      Description

      DescriptiveStatistics.windowSize has a setter which does validation and maintains the list if necessary.

      However the field is protected, so classes can ignore the setter.

      As it happens, this is exactly what the subclass ListUnivariateImpl.setWindowSize does.

      The field should be made private.

        Issue Links

          Activity

          Hide
          Thomas Neidhart added a comment -

          +1 for the change, but it would break source/binary compatibility thus postponing to 4.0

          Show
          Thomas Neidhart added a comment - +1 for the change, but it would break source/binary compatibility thus postponing to 4.0

            People

            • Assignee:
              Unassigned
              Reporter:
              Sebb
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Development