Uploaded image for project: 'Commons Math'
  1. Commons Math
  2. MATH-760

DescriptiveStatistics.windowSize has a getter and setter, but is protected, so subclasses can bypass the validation check in the setter

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 4.0
    • None
    • None

    Description

      DescriptiveStatistics.windowSize has a setter which does validation and maintains the list if necessary.

      However the field is protected, so classes can ignore the setter.

      As it happens, this is exactly what the subclass ListUnivariateImpl.setWindowSize does.

      The field should be made private.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MATH-1192 "Descriptive statistics" has a non-final protected field

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MATH-759 ListUnivariateImpl does not always access windowSize using synch.

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              Unassigned Unassigned
              sebb Sebb
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: