Uploaded image for project: 'Commons Math'
  1. Commons Math
  2. MATH-1014

Remove optimizer from constructor of "CurveFitter" subclasses

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.2
    • 3.3
    • None

    Description

      In package "o.a.c.m.fitting", the constructor of the concrete subclasses of "CurveFitter" (currently: "PolynomialFitter", "GaussianFitter", "HarmonicFitter") takes a "MultivariateVectorOptimizer" argument.

      However, assuming that there is one best choice for the optimizer (given the parametric function), this argument should not be left to the user's choice (i.e. it should be hidden within the class, and the best optimizer be transparently selected).

      Thus, I would propose to deprecate the non-default constructor.

      Attachments

        1. MATH-1014.zip
          7 kB
          Gilles Sadowski
        2. MATH-1014.zip
          8 kB
          Gilles Sadowski

        Issue Links

          Activity

            People

              erans Gilles Sadowski
              erans Gilles Sadowski
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: