[MASSEMBLY-966] Artifacts with classifiers are not included anymore

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Duplicate
• Affects Version/s: 3.4.0
• Component/s: dependencySet, filtering
• Assignee: Unassigned
• Reporter: Thomas Mortagne
• Created: 06/Jul/22 13:58
• Updated: 06/Jul/23 15:16
• Resolved: 06/Jul/23 15:16

Description

I just upgraded to 3.4.0 (from 3.3.0) and one of my dependencies with a classifier and supposed to be included is now skipped. I guess it's a consequence of MASSEMBLY-955.

In the pom the dependency is declared with

    <dependency>
      <groupId>org.eclipse.jetty</groupId>
      <artifactId>jetty-start</artifactId>
      <version>10.0.7</version>
      <classifier>shaded</classifier>
      <optional>true</optional>
    </dependency>

and assembly configuration looks like

<assembly>
  <id>distribution</id>
  <formats>
    <format>zip</format>
  </formats>
  <includeBaseDirectory>false</includeBaseDirectory>
  <dependencySets>
    <dependencySet>
      <outputFileNameMapping>start.jar</outputFileNameMapping>
      <outputDirectory>/jetty</outputDirectory>
      <includes>
        <include>org.eclipse.jetty:jetty-start:jar:shaded</include>
      </includes>
    </dependencySet>
[...]
  </dependencySets>
[...]
</assembly>

And I see the related warning in the log:

[INFO] --- maven-assembly-plugin:3.4.0:single (default) @ xwiki-platform-tool-jetty-resources ---
[INFO] Reading assembly descriptor: /media/DATA/xwiki/sources/xwiki-platform/xwiki-platform-tools/xwiki-platform-tool-jetty/xwiki-platform-tool-jetty-resources/src/main/assembly/distribution.xml
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o  'org.eclipse.jetty:jetty-start:jar:shaded'

[WARNING] The following patterns were never triggered in this artifact exclusion filter:
o  'org.eclipse.jetty:jetty-start:jar:shaded'

For more details the module can be found on https://github.com/xwiki/xwiki-platform/tree/xwiki-platform-14.5/xwiki-platform-tools/xwiki-platform-tool-jetty/xwiki-platform-tool-jetty-resources.

Issue Links

• duplicates: MASSEMBLY-969 Excludes filtering in 3.4.0 and 3.4.1 differs from 3.3.0
• is caused by: MASSEMBLY-955 dependencySet includes filter with classifier breaks include of artifacts without classifier