Uploaded image for project: 'Maven Assembly Plugin'
  1. Maven Assembly Plugin
  2. MASSEMBLY-938

includeSubModules==false and useAllReactorProjects warning changes behaviour

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 3.3.0
    • None
    • moduleSet
    • None
    • macOS, maven 3.6.3

    Description

      The following moduleset fails to include the license and readme and reports '[WARNING] The following patterns were never triggered in this artifact inclusion filter: o 'org.odpi.egeria:egeria:*'

      <!-- LICENSE & NOTICE and truststore from top level - this is a custom artifact -->
      <moduleSet>
      <useAllReactorProjects>true</useAllReactorProjects>
      <!-includeSubModules>false</includeSubModules->
      <includes>
      <!-- Full qualification here is groupId:artifactId:packaging:classifier:version -->
      <!-- This retrieves our extra 'root' pom we use for carrying non-java extras needed -->
      <include>org.odpi.egeria:egeria:*</include>
      </includes>
      <sources>
      <includeModuleDirectory>false</includeModuleDirectory>
      <fileSets>
      <fileSet>
      <outputDirectory>/</outputDirectory>
      <includes>
      <include>NOTICE</include>
      <include>LICENSE</include>
      <include>truststore.p12</include>
      </includes>
      </fileSet>
      </fileSets>
      </sources>
      </moduleSet>

      Uncommenting '<includeSubModules>false</includeSubModules>' results in a warning :

      15:48:20,349 [WARNING] includeSubModules == false is incompatible with useAllReactorProjects. Ignoring.

      To refactor, remove the <includeSubModules/> flag, and use the <includes/> and <excludes/> sections to fine-tune the modules included.

      However in this case there isn't a warning of a missing module AND the license/readme correctly gets included

      Is this a bug? It appears to be, since the warning says 'Ignoring' so the result should be the same as if it wasn't specified?

      In this particular case the module being referenced in this section is the top level pom (the ultimate parent of the module containing the assembly)

      originally posted thread to: https://lists.apache.org/thread.html/rddcad12fa9403fe86c6d0c378dc91b3236eea5df1ce85bc27319b9bf%40%3Cusers.maven.apache.org%3E

      Attachments

        Activity

          People

            Unassigned Unassigned
            jonesn Nigel Jones
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: