[MARMOTTA-671] Redundant conditions in an if statement

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.3.0
• Fix Version/s: 3.4.0
• Component/s: Client Library
• Assignee: Sergio Fernández
• Reporter: songwanging
• Created: 06/Dec/17 22:19
• Updated: 18/Jun/18 19:31
• Resolved: 08/Dec/17 04:18

Description

Our tool DeepTect has detected the following two pieces of buggy code snippet, in which the if branch has exactly the same conditions.

Path1: marmotta/client/marmotta-client-java/src/main/java/org/apache/marmotta/client/util/HTTPUtil.java

if (StringUtils.isNotBlank(config.getMarmottaUser()) && StringUtils.isNotBlank(config.getMarmottaUser())) {
...
}

Path2: marmotta/libraries/ldpath/ldpath-backend-linkeddata/src/main/java/org/apache/marmotta/ldpath/backend/linkeddata/LDCacheBackend.java

if(subject instanceof org.openrdf.model.URI && subject instanceof org.openrdf.model.URI) {
..
}

In the above code snippets, the if statement contains the same conditions