Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-924

TestPipes must not directly invoke 'main' of pipes as an exit from main could cause the testcase to crash.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.1
    • Fix Version/s: 0.20.1
    • Component/s: pipes
    • Labels:
      None

      Description

      TestPipes invokes the main method of the program running pipes. In MAPREDUCE-421, a change was made to the Pipes command runner to invoke System.exit after completion. This itself is a valid change because the pipes command runner is in itself a user facing program. But when combined with a testcase, it causes the testcase to crash rather than providing feedback on whether the test ran correctly or not.

      The testcase should be modified to use Tool instead of running main directly.

      1. patch-924.txt
        1 kB
        Amareshwari Sriramadasu
      2. patch-924-0.20.txt
        1 kB
        Amareshwari Sriramadasu

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        3d 2h 9m 1 Amareshwari Sriramadasu 31/Aug/09 11:08
        Patch Available Patch Available Resolved Resolved
        1d 7h 22m 1 Devaraj Das 01/Sep/09 18:31
        Hemanth Yamijala made changes -
        Summary TestPipes crashes on trunk TestPipes must not directly invoke 'main' of pipes as an exit from main could cause the testcase to crash.
        Description TestPipes crashes on trunk due to MAPREDUCE-421.
        Testcase should be modified to use Tool insteadof running main directly.
        TestPipes invokes the main method of the program running pipes. In MAPREDUCE-421, a change was made to the Pipes command runner to invoke System.exit after completion. This itself is a valid change because the pipes command runner is in itself a user facing program. But when combined with a testcase, it causes the testcase to crash rather than providing feedback on whether the test ran correctly or not.

        The testcase should be modified to use Tool instead of running main directly.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #70 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/70/)
        . Fixes the TestPipes testcase to use Tool. Contributed by Amareshwari Sriramadasu.

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #70 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/70/ ) . Fixes the TestPipes testcase to use Tool. Contributed by Amareshwari Sriramadasu.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #10 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/10/)
        . Fixes the TestPipes testcase to use Tool. Contributed by Amareshwari Sriramadasu.

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #10 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/10/ ) . Fixes the TestPipes testcase to use Tool. Contributed by Amareshwari Sriramadasu.
        Devaraj Das made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Devaraj Das added a comment -

        I just committed this. Thanks, Amareshwari!

        Show
        Devaraj Das added a comment - I just committed this. Thanks, Amareshwari!
        Hide
        Amareshwari Sriramadasu added a comment -

        -1 core tests. Is due to MAPREDUCE-880 and MAPREDUCE-943.

        Show
        Amareshwari Sriramadasu added a comment - -1 core tests. Is due to MAPREDUCE-880 and MAPREDUCE-943 .
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12418132/patch-924.txt
        against trunk revision 808730.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/26/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/26/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/26/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/26/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12418132/patch-924.txt against trunk revision 808730. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/26/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/26/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/26/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/26/console This message is automatically generated.
        Amareshwari Sriramadasu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Amareshwari Sriramadasu [ amareshwari ]
        Amareshwari Sriramadasu made changes -
        Attachment patch-924-0.20.txt [ 12418131 ]
        Attachment patch-924.txt [ 12418132 ]
        Hide
        Amareshwari Sriramadasu added a comment -

        Patch fixing the testcase.

        Show
        Amareshwari Sriramadasu added a comment - Patch fixing the testcase.
        Amareshwari Sriramadasu made changes -
        Field Original Value New Value
        Fix Version/s 0.20.1 [ 12314047 ]
        Fix Version/s 0.21.0 [ 12314045 ]
        Affects Version/s 0.20.1 [ 12314047 ]
        Amareshwari Sriramadasu created issue -

          People

          • Assignee:
            Amareshwari Sriramadasu
            Reporter:
            Amareshwari Sriramadasu
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development