Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-924

TestPipes must not directly invoke 'main' of pipes as an exit from main could cause the testcase to crash.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.1
    • Fix Version/s: 0.20.1
    • Component/s: pipes
    • Labels:
      None

      Description

      TestPipes invokes the main method of the program running pipes. In MAPREDUCE-421, a change was made to the Pipes command runner to invoke System.exit after completion. This itself is a valid change because the pipes command runner is in itself a user facing program. But when combined with a testcase, it causes the testcase to crash rather than providing feedback on whether the test ran correctly or not.

      The testcase should be modified to use Tool instead of running main directly.

      1. patch-924.txt
        1 kB
        Amareshwari Sriramadasu
      2. patch-924-0.20.txt
        1 kB
        Amareshwari Sriramadasu

        Activity

        Hemanth Yamijala made changes -
        Summary TestPipes crashes on trunk TestPipes must not directly invoke 'main' of pipes as an exit from main could cause the testcase to crash.
        Description TestPipes crashes on trunk due to MAPREDUCE-421.
        Testcase should be modified to use Tool insteadof running main directly.
        TestPipes invokes the main method of the program running pipes. In MAPREDUCE-421, a change was made to the Pipes command runner to invoke System.exit after completion. This itself is a valid change because the pipes command runner is in itself a user facing program. But when combined with a testcase, it causes the testcase to crash rather than providing feedback on whether the test ran correctly or not.

        The testcase should be modified to use Tool instead of running main directly.
        Devaraj Das made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Amareshwari Sriramadasu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Amareshwari Sriramadasu [ amareshwari ]
        Amareshwari Sriramadasu made changes -
        Attachment patch-924-0.20.txt [ 12418131 ]
        Attachment patch-924.txt [ 12418132 ]
        Amareshwari Sriramadasu made changes -
        Field Original Value New Value
        Fix Version/s 0.20.1 [ 12314047 ]
        Fix Version/s 0.21.0 [ 12314045 ]
        Affects Version/s 0.20.1 [ 12314047 ]
        Amareshwari Sriramadasu created issue -

          People

          • Assignee:
            Amareshwari Sriramadasu
            Reporter:
            Amareshwari Sriramadasu
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development