Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: examples
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The PiEstimator example mainly illustrates evaluating arbitrary integrals numerically by Map/Reduce jobs but not focusing on computing Pi. The name "PiEstimator" is misleading.

      1. m874_20090817_commit.patch
        5 kB
        Tsz Wo Nicholas Sze
      2. m874_20090817_hudson.patch
        28 kB
        Tsz Wo Nicholas Sze
      3. m874_20090817.patch
        18 kB
        Tsz Wo Nicholas Sze
      4. m874_20090814.patch
        17 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #65 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/65/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #65 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/65/ )
          Tsz Wo Nicholas Sze made changes -
          Link This issue is related to HDFS-568 [ HDFS-568 ]
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.21.0 [ 12314045 ]
          Resolution Fixed [ 1 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          The failed tests are not related.

          I have committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - The failed tests are not related. I have committed this.
          Tsz Wo Nicholas Sze made changes -
          Attachment m874_20090817_commit.patch [ 12417329 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          > For committing this, please first run "svn mv src/examples/org/apache/hadoop/examples/PiEstimator.java src/examples/org/apache/hadoop/examples/QuasiMonteCarlo.java" and then apply m874_20090817.patch

          m874_20090817.patch should be m874_20090817_commit.patch because PiEstimator.java is already removed.

          Show
          Tsz Wo Nicholas Sze added a comment - > For committing this, please first run "svn mv src/examples/org/apache/hadoop/examples/PiEstimator.java src/examples/org/apache/hadoop/examples/QuasiMonteCarlo.java" and then apply m874_20090817.patch m874_20090817.patch should be m874_20090817_commit.patch because PiEstimator.java is already removed.
          Hide
          Owen O'Malley added a comment -

          +1

          Show
          Owen O'Malley added a comment - +1
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12416787/m874_20090817_hudson.patch
          against trunk revision 805081.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/487/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/487/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/487/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/487/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12416787/m874_20090817_hudson.patch against trunk revision 805081. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/487/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/487/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/487/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/487/console This message is automatically generated.
          Tsz Wo Nicholas Sze made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Tsz Wo Nicholas Sze made changes -
          Attachment m874_20090817_hudson.patch [ 12416787 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          m874_20090817_hudson.patch: for submitting to Hudson. Same code change as m874_20090817.patch.

          For committing this, please first run "svn mv src/examples/org/apache/hadoop/examples/PiEstimator.java src/examples/org/apache/hadoop/examples/QuasiMonteCarlo.java" and then apply m874_20090817.patch

          Show
          Tsz Wo Nicholas Sze added a comment - m874_20090817_hudson.patch: for submitting to Hudson. Same code change as m874_20090817.patch. For committing this, please first run "svn mv src/examples/org/apache/hadoop/examples/PiEstimator.java src/examples/org/apache/hadoop/examples/QuasiMonteCarlo.java" and then apply m874_20090817.patch
          Tsz Wo Nicholas Sze made changes -
          Attachment m874_20090817.patch [ 12416786 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          m874_20090817.patch: also renamed estimate(..) to estimatePi(..).

          Show
          Tsz Wo Nicholas Sze added a comment - m874_20090817.patch: also renamed estimate(..) to estimatePi(..).
          Tsz Wo Nicholas Sze made changes -
          Field Original Value New Value
          Attachment m874_20090814.patch [ 12416620 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          m874_20090814.patch: renamed PiEstimator, PiMapper and PiReducer to QuasiMonteCarlo, QmcMapper and QmcReducer, respectively.

          Show
          Tsz Wo Nicholas Sze added a comment - m874_20090814.patch: renamed PiEstimator, PiMapper and PiReducer to QuasiMonteCarlo, QmcMapper and QmcReducer, respectively.
          Tsz Wo Nicholas Sze created issue -

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development