Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      MAPREDUCE-716 introduces javac warnings

      1. MAPREDUCE-792.patch
        0.8 kB
        Aaron Kimball
      2. MAPREDUCE-792.2.patch
        0.8 kB
        Aaron Kimball

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          2h 44m 1 Aaron Kimball 23/Jul/09 03:20
          Open Open Patch Available Patch Available
          1m 21s 2 Aaron Kimball 23/Jul/09 03:20
          Patch Available Patch Available Resolved Resolved
          7d 15h 29m 1 Tsz Wo Nicholas Sze 30/Jul/09 18:49
          Resolved Resolved Closed Closed
          390d 2h 25m 1 Tom White 24/Aug/10 21:14
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #35 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/35/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #35 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/35/ )
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.21.0 [ 12314045 ]
          Resolution Fixed [ 1 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          No new tests added since the change is very simple.

          I have committed this. Thanks, Aaron!

          Show
          Tsz Wo Nicholas Sze added a comment - No new tests added since the change is very simple. I have committed this. Thanks, Aaron!
          Hide
          Aaron Kimball added a comment -

          unrelated test failures

          Show
          Aaron Kimball added a comment - unrelated test failures
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12414303/MAPREDUCE-792.2.patch
          against trunk revision 799126.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/428/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/428/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/428/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/428/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12414303/MAPREDUCE-792.2.patch against trunk revision 799126. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/428/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/428/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/428/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/428/console This message is automatically generated.
          Tsz Wo Nicholas Sze made changes -
          Hadoop Flags [Reviewed]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
          Aaron Kimball made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Aaron Kimball made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Aaron Kimball made changes -
          Attachment MAPREDUCE-792.2.patch [ 12414303 ]
          Hide
          Aaron Kimball added a comment -

          So it is! New patch.

          Show
          Aaron Kimball added a comment - So it is! New patch.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          It is better to have the @SuppressWarnings right above the required code. i.e.

          -    Class inputClass = dbConf.getInputClass();
          +    @SuppressWarnings("unchecked")
          +    Class<T> inputClass = (Class<T>)dbConf.getInputClass();
          
          Show
          Tsz Wo Nicholas Sze added a comment - It is better to have the @SuppressWarnings right above the required code. i.e. - Class inputClass = dbConf.getInputClass(); + @SuppressWarnings( "unchecked" ) + Class <T> inputClass = ( Class <T>)dbConf.getInputClass();
          Aaron Kimball made changes -
          Link This issue relates to MAPREDUCE-716 [ MAPREDUCE-716 ]
          Aaron Kimball made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Aaron Kimball made changes -
          Field Original Value New Value
          Attachment MAPREDUCE-792.patch [ 12414290 ]
          Hide
          Aaron Kimball added a comment -

          Attaching patch to suppress the warnings. The typecast can't be verified at runtime due to how Java generics / type erasure works, so suppressed warnings in the method. No new tests because it's a trivial patch.

          Show
          Aaron Kimball added a comment - Attaching patch to suppress the warnings. The typecast can't be verified at runtime due to how Java generics / type erasure works, so suppressed warnings in the method. No new tests because it's a trivial patch.
          Aaron Kimball created issue -

            People

            • Assignee:
              Aaron Kimball
              Reporter:
              Aaron Kimball
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development