Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-764

TypedBytesInput's readRaw() does not preserve custom type codes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.21.0, 1.0.2
    • Fix Version/s: 0.21.0, 1.0.2
    • Component/s: contrib/streaming
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The typed bytes format supports byte sequences of the form <custom type code> <length> <bytes>. When reading such a sequence via TypedBytesInput's readRaw() method, however, the returned sequence currently is 0 <length> <bytes> (0 is the type code for a bytes array), which leads to bugs such as the one described here.

      1. MAPREDUCE-764.patch
        3 kB
        Klaas Bosteels
      2. MAPREDUCE-764.patch
        3 kB
        Klaas Bosteels

        Activity

        Hide
        Arun C Murthy added a comment -

        Thanks Matt. I've committed this to branch-1 after running all tests.

        Show
        Arun C Murthy added a comment - Thanks Matt. I've committed this to branch-1 after running all tests.
        Hide
        Matt Foley added a comment -

        +1. Please push it to both branch-1 and branch-1.0. Thanks.

        Show
        Matt Foley added a comment - +1. Please push it to both branch-1 and branch-1.0. Thanks.
        Hide
        Arun C Murthy added a comment -

        Matt - Klaas's patch applies clean to branch-1. I'd like to push it in for hadoop-1.0.2, you ok? Thanks.

        Show
        Arun C Murthy added a comment - Matt - Klaas's patch applies clean to branch-1. I'd like to push it in for hadoop-1.0.2, you ok? Thanks.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #20 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/20/)
        . TypedBytesInput's readRaw() does not preserve custom type codes. Contributed by Klaas Bosteels.

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #20 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/20/ ) . TypedBytesInput's readRaw() does not preserve custom type codes. Contributed by Klaas Bosteels.
        Hide
        Tom White added a comment -

        +1

        I've just committed this. Thanks Klaas!

        Show
        Tom White added a comment - +1 I've just committed this. Thanks Klaas!
        Hide
        Klaas Bosteels added a comment -

        Making this a blocker since it should really go into 0.21.

        Show
        Klaas Bosteels added a comment - Making this a blocker since it should really go into 0.21.
        Hide
        Klaas Bosteels added a comment -

        Again, the unit test failures don't seem to be related to the patch.

        Show
        Klaas Bosteels added a comment - Again, the unit test failures don't seem to be related to the patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12413658/MAPREDUCE-764.patch
        against trunk revision 794637.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/403/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/403/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/403/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/403/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12413658/MAPREDUCE-764.patch against trunk revision 794637. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/403/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/403/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/403/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/403/console This message is automatically generated.
        Hide
        Klaas Bosteels added a comment -

        Fixed the javadoc warning. The failed unit tests seem to be unrelated to the patch.

        Show
        Klaas Bosteels added a comment - Fixed the javadoc warning. The failed unit tests seem to be unrelated to the patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12413534/MAPREDUCE-764.patch
        against trunk revision 794324.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/397/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/397/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/397/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/397/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12413534/MAPREDUCE-764.patch against trunk revision 794324. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/397/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/397/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/397/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/397/console This message is automatically generated.

          People

          • Assignee:
            Klaas Bosteels
            Reporter:
            Klaas Bosteels
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development