[MAPREDUCE-7199] HsJobsBlock reuse JobACLsManager for checkAccess

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0, 3.3.1
• Fix Version/s: 3.4.0, 3.3.1
• Component/s: mrv2
• Target Version/s: 3.4.0, 3.3.1
• Hadoop Flags: Reviewed
• Assignee: Bilwa S T
• Reporter: Bibin Chundatt
• Created: 23/Apr/19 09:02
• Updated: 11/Feb/24 06:15
• Resolved: 18/Apr/20 14:24

Description

Reuse JobAclManager.checkAccess

 
 private boolean checkAccess(String userName) {
    if(!areAclsEnabled) {
      return true;
    }

    // User could see its own job.
    if (ugi.getShortUserName().equals(userName)) {
      return true;
    }

    // Admin could also see all jobs
    if (adminAclList != null && adminAclList.isUserAllowed(ugi)) {
      return true;
    }
    return false;
  }

jobACLsManager
          .checkAccess(ugi, JobACL.VIEW_JOB, ..
              new AccessControlList()))