Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-686

Move TestSpeculativeExecution.Fake* into a separate class so that it can be used by other tests also

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Consolidate the Mock Objects used for testing in a separate class(FakeObjectUtiltities) to ease re-usability

      Description

      TestSpeculativeExecution has some utility classes in FakeJobTracker and FakeJobInProgress that could be put to use by other tests as well. It makes sense to move these to a separate class

      1. mapred-686-v2.patch
        20 kB
        Jothi Padmanabhan
      2. mapred-686-v3.patch
        21 kB
        Jothi Padmanabhan
      3. mapreduce-686.patch
        18 kB
        Jothi Padmanabhan
      4. mapreduce-686-v1.patch
        18 kB
        Jothi Padmanabhan
      5. MAPREDUCE-686-y20.patch
        9 kB
        Hemanth Yamijala
      6. mapreduce-686-yahoo-0.20-v2.patch
        56 kB
        Amar Kamat
      7. mapreduce-686-yahoo-0.20-v5.2.patch
        51 kB
        Amar Kamat
      8. mapreduce-686-yahoo-0.20-v5.patch
        50 kB
        Amar Kamat

        Activity

        Hide
        Jothi Padmanabhan added a comment -

        Straight forward patch.
        Also modified TestTaskTrackerBlacklisting so that setup/tearDown is called only once.

        Show
        Jothi Padmanabhan added a comment - Straight forward patch. Also modified TestTaskTrackerBlacklisting so that setup/tearDown is called only once.
        Hide
        Jothi Padmanabhan added a comment -

        Minor change from the previous patch – removed some redundant methods from TestTaskTrackerBlacklisting.FakeJobTracker

        Show
        Jothi Padmanabhan added a comment - Minor change from the previous patch – removed some redundant methods from TestTaskTrackerBlacklisting.FakeJobTracker
        Hide
        Giridharan Kesavan added a comment -

        changing the status to patch available to test the hudson mapred patch queue.

        Show
        Giridharan Kesavan added a comment - changing the status to patch available to test the hudson mapred patch queue.
        Hide
        Sreekanth Ramakrishnan added a comment -

        +1 to the patch.

        Show
        Sreekanth Ramakrishnan added a comment - +1 to the patch.
        Hide
        Jothi Padmanabhan added a comment -

        Fixing a wrong comment that got it in the previous patch. Also, modified TestTrackerBlacklisting so that 80 column limit is honoured

        Show
        Jothi Padmanabhan added a comment - Fixing a wrong comment that got it in the previous patch. Also, modified TestTrackerBlacklisting so that 80 column limit is honoured
        Hide
        Jothi Padmanabhan added a comment -

        This is only a test case change. I tested the modified test cases and they run fine.

        Test Patch Results:
        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 10 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec]

        Show
        Jothi Padmanabhan added a comment - This is only a test case change. I tested the modified test cases and they run fine. Test Patch Results: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 10 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec]
        Hide
        Sharad Agarwal added a comment -

        Minor: The latest patch still adds lines exceeding 80 columns at places. Should we fix this ?

        Show
        Sharad Agarwal added a comment - Minor: The latest patch still adds lines exceeding 80 columns at places. Should we fix this ?
        Hide
        Jothi Padmanabhan added a comment -

        Corrected the 80 column violations. Eclipse misled me last time with the 80 column margin

        Show
        Jothi Padmanabhan added a comment - Corrected the 80 column violations. Eclipse misled me last time with the 80 column margin
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12412386/mapred-686-v3.patch
        against trunk revision 790543.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 10 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/337/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/337/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/337/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/337/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12412386/mapred-686-v3.patch against trunk revision 790543. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 10 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/337/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/337/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/337/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/337/console This message is automatically generated.
        Hide
        Jothi Padmanabhan added a comment -

        Test failures are unrelated

        Show
        Jothi Padmanabhan added a comment - Test failures are unrelated
        Hide
        Sharad Agarwal added a comment -

        I committed this. Thanks Jothi.

        Show
        Sharad Agarwal added a comment - I committed this. Thanks Jothi.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #15 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/15/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #15 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/15/ )
        Hide
        Amar Kamat added a comment -

        Attaching an example patch for Yahoo!'s distribution of Hadoop-0.20 not to be committed. This patch backports the FakeObjects utility and framework changes required for supporting the same. test-patch passed. All ant tests except the following passed :

        • TestJobHistory
        • TestReduceFetch
        • TestStreamingExitStatus
          -TestJobTrackerRestartWithCS

        All of the above failures are known issues. TestJobHistory, TestReduceFetch and TestStreamingExitStatus passed when I reran them on my local box. TestJobTrackerRestartWithCS timesout consistently.

        Show
        Amar Kamat added a comment - Attaching an example patch for Yahoo!'s distribution of Hadoop-0.20 not to be committed. This patch backports the FakeObjects utility and framework changes required for supporting the same. test-patch passed. All ant tests except the following passed : TestJobHistory TestReduceFetch TestStreamingExitStatus -TestJobTrackerRestartWithCS All of the above failures are known issues. TestJobHistory, TestReduceFetch and TestStreamingExitStatus passed when I reran them on my local box. TestJobTrackerRestartWithCS timesout consistently.
        Hide
        Amar Kamat added a comment -

        Attaching a patch for Yahoo!'s dist of Hadoop not to be committed. Test-patch passed locally. Ant tests modified/affected by this patch passed locally.

        Show
        Amar Kamat added a comment - Attaching a patch for Yahoo!'s dist of Hadoop not to be committed. Test-patch passed locally. Ant tests modified/affected by this patch passed locally.
        Hide
        Amar Kamat added a comment -

        Attaching a patch for Yahoo!'s distribution of Hadoop not to be committed. Factored out some commonly used code from testcases to JobInProgress constructor (meant for testcases). test-patch passed on my local box. All ant tests except TestJobHistory, TestReduceFetch, TestHdfsProxy and TestStreamingExitStatus have passed. None of the failed tests seem to be related to this patch.

        Show
        Amar Kamat added a comment - Attaching a patch for Yahoo!'s distribution of Hadoop not to be committed. Factored out some commonly used code from testcases to JobInProgress constructor (meant for testcases). test-patch passed on my local box. All ant tests except TestJobHistory, TestReduceFetch, TestHdfsProxy and TestStreamingExitStatus have passed. None of the failed tests seem to be related to this patch.
        Hide
        Hemanth Yamijala added a comment -

        Updating patch for earlier hadoop version, on behalf of Amar. Not for commit.

        Show
        Hemanth Yamijala added a comment - Updating patch for earlier hadoop version, on behalf of Amar. Not for commit.

          People

          • Assignee:
            Jothi Padmanabhan
            Reporter:
            Jothi Padmanabhan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development