String secretValueStr = new String (secretValue);
String secretValueStr = new String(secretValue, StandardCharsets.UTF_8);
2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11361 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11361/)
MAPREDUCE-6855. Specify charset when create String in (aajisaka: rev 14413989cac9acc1fa6f8d330fac32f772613325)
Committed this to trunk, branch-2, and branch-2.8. Thanks Kai Sasaki for the contribution!
This message was automatically generated.
Do you think we need to detect this type of bug even in test code? I'm wondering it might be overkill.
Agreed that it might be overkill. Thank you for taking this issue on.
Sangjin Lee Akira Ajisaka Thanks for pointing out. Do you think we need to detect this type of bug even in test code? I'm wondering it might be overkill.
Anyway we can fix the code in CredentialsTestJob.
It would be great if we can catch things like this with a findbugs rule.
Yes, findbugs can detect this bug pattern, but only production code. Test code is ignored by default.
It would be great if we can catch things like this with a findbugs rule. Do you know if that is straightforward?