Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6753

Variable in byte printed directly in mapreduce client

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Similar to the fix for HBASE-623, in file:

      hadoop-rel-release-2.7.2/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/security/CredentialsTestJob.java

      in line 61, the system out print a byte variable secretValue.

      System.out.println(secretValue);
      
      1. MAPREDUCE-6753.03.patch
        1 kB
        Kai Sasaki
      2. MAPREDUCE-6753.02.patch
        1 kB
        Kai Sasaki
      3. MAPREDUCE-6753.01.patch
        3 kB
        Kai Sasaki

        Activity

        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11337 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11337/)
        MAPREDUCE-6753. Variable in byte printed directly in mapreduce client. (aajisaka: rev 19a1fc6373f0dea56e5845f19990d469428489bc)

        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/security/CredentialsTestJob.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11337 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11337/ ) MAPREDUCE-6753 . Variable in byte printed directly in mapreduce client. (aajisaka: rev 19a1fc6373f0dea56e5845f19990d469428489bc) (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/security/CredentialsTestJob.java
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, and branch-2.8. Thanks all who contributed to this issue.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks all who contributed to this issue.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, thanks Kai Sasaki and Haibo Chen.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, thanks Kai Sasaki and Haibo Chen .
        Hide
        haibochen Haibo Chen added a comment -

        +1 non-binding on the latest patch.

        Show
        haibochen Haibo Chen added a comment - +1 non-binding on the latest patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 34s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 13m 48s trunk passed
        +1 compile 0m 25s trunk passed
        +1 checkstyle 0m 18s trunk passed
        +1 mvnsite 0m 25s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 0m 24s trunk passed
        +1 javadoc 0m 12s trunk passed
        +1 mvninstall 0m 22s the patch passed
        +1 compile 0m 19s the patch passed
        +1 javac 0m 19s the patch passed
        +1 checkstyle 0m 15s the patch passed
        +1 mvnsite 0m 21s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 28s the patch passed
        +1 javadoc 0m 9s the patch passed
        +1 unit 115m 20s hadoop-mapreduce-client-jobclient in the patch passed.
        +1 asflicense 0m 29s The patch does not generate ASF License warnings.
        135m 2s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12854768/MAPREDUCE-6753.03.patch
        JIRA Issue MAPREDUCE-6753
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux fab43a6cc98f 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 05391c1
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6905/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6905/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 34s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 13m 48s trunk passed +1 compile 0m 25s trunk passed +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 25s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 24s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 22s the patch passed +1 compile 0m 19s the patch passed +1 javac 0m 19s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 28s the patch passed +1 javadoc 0m 9s the patch passed +1 unit 115m 20s hadoop-mapreduce-client-jobclient in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 135m 2s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12854768/MAPREDUCE-6753.03.patch JIRA Issue MAPREDUCE-6753 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fab43a6cc98f 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 05391c1 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6905/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6905/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        lewuathe Kai Sasaki added a comment -

        Haibo Chen Thanks for comment. I think the both case. Secret value is thought not to be printed initially. But anyway it's printed as byte[] value. We cannot see the secret value even if it's printed. So it should be printed as string if it needs to be printed.

        Show
        lewuathe Kai Sasaki added a comment - Haibo Chen Thanks for comment. I think the both case. Secret value is thought not to be printed initially. But anyway it's printed as byte[] value. We cannot see the secret value even if it's printed. So it should be printed as string if it needs to be printed.
        Hide
        haibochen Haibo Chen added a comment -

        Kai Sasaki, thanks for the quick update! While looking at this description again, it does not seem clear to me what issue this jira is reporting.
        Is the problem that the secret value should not be printed out? Or is it that the byte content is not printed out? If it is the former, printing is probably OK given that this is a test. If it is the latter, I think we should convert the byte array to String and print it out.

        Show
        haibochen Haibo Chen added a comment - Kai Sasaki , thanks for the quick update! While looking at this description again, it does not seem clear to me what issue this jira is reporting. Is the problem that the secret value should not be printed out? Or is it that the byte content is not printed out? If it is the former, printing is probably OK given that this is a test. If it is the latter, I think we should convert the byte array to String and print it out.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 22m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 14m 6s trunk passed
        +1 compile 0m 24s trunk passed
        +1 checkstyle 0m 18s trunk passed
        +1 mvnsite 0m 25s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 0m 24s trunk passed
        +1 javadoc 0m 13s trunk passed
        +1 mvninstall 0m 20s the patch passed
        +1 compile 0m 20s the patch passed
        +1 javac 0m 20s the patch passed
        +1 checkstyle 0m 14s the patch passed
        +1 mvnsite 0m 22s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 27s the patch passed
        +1 javadoc 0m 9s the patch passed
        +1 unit 107m 25s hadoop-mapreduce-client-jobclient in the patch passed.
        +1 asflicense 0m 28s The patch does not generate ASF License warnings.
        148m 50s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12854211/MAPREDUCE-6753.02.patch
        JIRA Issue MAPREDUCE-6753
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2f36af303fd6 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a207aa9
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6901/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6901/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 22m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 14m 6s trunk passed +1 compile 0m 24s trunk passed +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 25s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 24s trunk passed +1 javadoc 0m 13s trunk passed +1 mvninstall 0m 20s the patch passed +1 compile 0m 20s the patch passed +1 javac 0m 20s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvnsite 0m 22s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 27s the patch passed +1 javadoc 0m 9s the patch passed +1 unit 107m 25s hadoop-mapreduce-client-jobclient in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 148m 50s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12854211/MAPREDUCE-6753.02.patch JIRA Issue MAPREDUCE-6753 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2f36af303fd6 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a207aa9 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6901/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6901/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        lewuathe Kai Sasaki added a comment -

        Haibo Chen Thanks for checking! The format violates checkstyle but as you said it's unrelated. I updated.

        Show
        lewuathe Kai Sasaki added a comment - Haibo Chen Thanks for checking! The format violates checkstyle but as you said it's unrelated. I updated.
        Hide
        haibochen Haibo Chen added a comment -

        Thanks Kai Sasaki for the patch! Can you remove the format changes in your patch since they are unrelated to this change?

        Show
        haibochen Haibo Chen added a comment - Thanks Kai Sasaki for the patch! Can you remove the format changes in your patch since they are unrelated to this change?

          People

          • Assignee:
            lewuathe Kai Sasaki
            Reporter:
            chenfsd Nemo Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development