Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha1
    • Component/s: mrv2
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      JHS today displays all Job conf properties in Web UI directly. Users may have some credentials or any sensitive information they added to the job conf but do not want to be shown in Web UI. It'd be nice if we can allow users to specify a set of properties which JHS will filter out when Job conf is displayed.

      1. mapreduce6741.001.patch
        8 kB
        Haibo Chen
      2. mapreduce6741.002.patch
        8 kB
        Haibo Chen
      3. mapreduce6741.003.patch
        8 kB
        Haibo Chen
      4. mapreduce6741.004.patch
        14 kB
        Haibo Chen
      5. mapreduce6741.005.patch
        14 kB
        Haibo Chen
      6. mapreduce6741.006.patch
        14 kB
        Haibo Chen
      7. mapreduce6741.branch-2.8.patch
        14 kB
        Haibo Chen

        Activity

        Hide
        jlowe Jason Lowe added a comment -

        Anyone who has access to JHS web UI essentially has access to Job Conf of any other users' job.

        This is not true. The job's setting for mapreduce.job.acl-view-job is respected by the history server, and users who do not have view access will not be able to see the job's configuration even though they have access to the JHS web UI.

        Having the ability to filter individual conf keys is one thing, but they should not be completely wide-open today unless the user didn't bother to restrict the visibility of their job.

        Show
        jlowe Jason Lowe added a comment - Anyone who has access to JHS web UI essentially has access to Job Conf of any other users' job. This is not true. The job's setting for mapreduce.job.acl-view-job is respected by the history server, and users who do not have view access will not be able to see the job's configuration even though they have access to the JHS web UI. Having the ability to filter individual conf keys is one thing, but they should not be completely wide-open today unless the user didn't bother to restrict the visibility of their job.
        Hide
        haibochen Haibo Chen added a comment -

        Thanks Jason Lowe for pointing out my false statement above. Will update the jira description.

        Show
        haibochen Haibo Chen added a comment - Thanks Jason Lowe for pointing out my false statement above. Will update the jira description.
        Hide
        jlowe Jason Lowe added a comment -

        Will this filtering be for all users or will it still show the properties for the owner of the job?

        Show
        jlowe Jason Lowe added a comment - Will this filtering be for all users or will it still show the properties for the owner of the job?
        Hide
        jlowe Jason Lowe added a comment -

        Another requirements clarification: when the properties are to be hidden, will they be completely removed from the output or will the keys appear with redacted values?

        Show
        jlowe Jason Lowe added a comment - Another requirements clarification: when the properties are to be hidden, will they be completely removed from the output or will the keys appear with redacted values?
        Hide
        haibochen Haibo Chen added a comment -

        I am thinking of redacting the values in the UI for all users to make it simple. This essentially comes from requests from customers who have legacy MR jobs that used S3/Azure as input&output. Instead of using CredentialProvider, they put their credentials directly in JobConf, which is then displayed directly JHS UI. Some of them are aware of job ACL, but also want to disallow queue admins or whoever are always given access to all jobs by JHS, to easily access their credentials. Redacting the credentials in UI doesn't really solve the security problem. The credentials are still stored in jobconf in HDFS after all. But it does make the credentials less exposed.

        Show
        haibochen Haibo Chen added a comment - I am thinking of redacting the values in the UI for all users to make it simple. This essentially comes from requests from customers who have legacy MR jobs that used S3/Azure as input&output. Instead of using CredentialProvider, they put their credentials directly in JobConf, which is then displayed directly JHS UI. Some of them are aware of job ACL, but also want to disallow queue admins or whoever are always given access to all jobs by JHS, to easily access their credentials. Redacting the credentials in UI doesn't really solve the security problem. The credentials are still stored in jobconf in HDFS after all. But it does make the credentials less exposed.
        Hide
        jlowe Jason Lowe added a comment -

        If that's the case, would it make more sense to have the AM redact the values when it writes out the jobconf that will be picked up by the JHS? Then even admins can't see it once the job is completed because there should be no more copies lying around with the original values, even in HDFS.

        Show
        jlowe Jason Lowe added a comment - If that's the case, would it make more sense to have the AM redact the values when it writes out the jobconf that will be picked up by the JHS? Then even admins can't see it once the job is completed because there should be no more copies lying around with the original values, even in HDFS.
        Hide
        haibochen Haibo Chen added a comment - - edited

        Good point! I have not thought about updating the jobconf file in HDFS. A question that may or may not be relevant to this. I notice that for every job there are always two job conf files. One file, named job.xml, is submitted by the client and localized as task container resource. The other, named $(jobid)_conf.xml, is created by JobHistoryEventHandler and loaded by JHS. Any particular reason why we have two files lying around for one job?

        Show
        haibochen Haibo Chen added a comment - - edited Good point! I have not thought about updating the jobconf file in HDFS. A question that may or may not be relevant to this. I notice that for every job there are always two job conf files. One file, named job.xml, is submitted by the client and localized as task container resource. The other, named $(jobid)_conf.xml, is created by JobHistoryEventHandler and loaded by JHS. Any particular reason why we have two files lying around for one job?
        Hide
        jlowe Jason Lowe added a comment -

        The job.xml is necessary to get the job going – it's the base conf to be used by the AM and all tasks. The other conf file is only created for historical record. We could probably just copy job.xml, but that would be more expensive in practice than just having the AM write out its own conf.

        Note that the two files aren't lying around at the same time very long. The job.xml file is in the staging directory which is deleted shortly after the copy is made for the JHS.

        Show
        jlowe Jason Lowe added a comment - The job.xml is necessary to get the job going – it's the base conf to be used by the AM and all tasks. The other conf file is only created for historical record. We could probably just copy job.xml, but that would be more expensive in practice than just having the AM write out its own conf. Note that the two files aren't lying around at the same time very long. The job.xml file is in the staging directory which is deleted shortly after the copy is made for the JHS.
        Hide
        haibochen Haibo Chen added a comment -

        Thanks a lot for the detailed explanation, Jason. It now makes sense to me why a job_conf.xml is created. Will proceed with your suggestion.

        Show
        haibochen Haibo Chen added a comment - Thanks a lot for the detailed explanation, Jason. It now makes sense to me why a job_conf.xml is created. Will proceed with your suggestion.
        Hide
        haibochen Haibo Chen added a comment -

        Uploading a patch that does the redaction in JobHistoryEventHandler. Also verified in JHS UI.

        Show
        haibochen Haibo Chen added a comment - Uploading a patch that does the redaction in JobHistoryEventHandler. Also verified in JHS UI.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 22s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 6m 56s trunk passed
        +1 compile 1m 36s trunk passed
        +1 checkstyle 0m 38s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 29s trunk passed
        +1 findbugs 1m 24s trunk passed
        +1 javadoc 0m 37s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 0m 44s the patch passed
        +1 compile 1m 32s the patch passed
        +1 javac 1m 32s the patch passed
        -1 checkstyle 0m 39s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 2 new + 891 unchanged - 0 fixed = 893 total (was 891)
        +1 mvnsite 0m 56s the patch passed
        +1 mvneclipse 0m 25s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 38s the patch passed
        +1 javadoc 0m 37s the patch passed
        +1 unit 2m 8s hadoop-mapreduce-client-core in the patch passed.
        +1 unit 9m 31s hadoop-mapreduce-client-app in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        32m 32s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820301/mapreduce6741.001.patch
        JIRA Issue MAPREDUCE-6741
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 45cf0d51422f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5aace38
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6640/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6640/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6640/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 56s trunk passed +1 compile 1m 36s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 29s trunk passed +1 findbugs 1m 24s trunk passed +1 javadoc 0m 37s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 44s the patch passed +1 compile 1m 32s the patch passed +1 javac 1m 32s the patch passed -1 checkstyle 0m 39s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 2 new + 891 unchanged - 0 fixed = 893 total (was 891) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 38s the patch passed +1 javadoc 0m 37s the patch passed +1 unit 2m 8s hadoop-mapreduce-client-core in the patch passed. +1 unit 9m 31s hadoop-mapreduce-client-app in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 32m 32s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820301/mapreduce6741.001.patch JIRA Issue MAPREDUCE-6741 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 45cf0d51422f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5aace38 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6640/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6640/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6640/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        haibochen Haibo Chen added a comment -

        Patch updated to fix the checkstyle issues.

        Show
        haibochen Haibo Chen added a comment - Patch updated to fix the checkstyle issues.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 8s Maven dependency ordering for branch
        +1 mvninstall 7m 43s trunk passed
        +1 compile 1m 59s trunk passed
        +1 checkstyle 0m 42s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 31s trunk passed
        +1 findbugs 1m 24s trunk passed
        +1 javadoc 0m 37s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 0m 44s the patch passed
        +1 compile 1m 35s the patch passed
        +1 javac 1m 35s the patch passed
        -1 checkstyle 0m 34s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 891 unchanged - 0 fixed = 892 total (was 891)
        +1 mvnsite 0m 54s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 35s the patch passed
        +1 javadoc 0m 33s the patch passed
        +1 unit 2m 0s hadoop-mapreduce-client-core in the patch passed.
        +1 unit 8m 52s hadoop-mapreduce-client-app in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        32m 43s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820311/mapreduce6741.002.patch
        JIRA Issue MAPREDUCE-6741
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1888f22eb4fa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d84ab8a
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6641/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6641/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6641/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 7m 43s trunk passed +1 compile 1m 59s trunk passed +1 checkstyle 0m 42s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 31s trunk passed +1 findbugs 1m 24s trunk passed +1 javadoc 0m 37s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 44s the patch passed +1 compile 1m 35s the patch passed +1 javac 1m 35s the patch passed -1 checkstyle 0m 34s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 891 unchanged - 0 fixed = 892 total (was 891) +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 35s the patch passed +1 javadoc 0m 33s the patch passed +1 unit 2m 0s hadoop-mapreduce-client-core in the patch passed. +1 unit 8m 52s hadoop-mapreduce-client-app in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 32m 43s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820311/mapreduce6741.002.patch JIRA Issue MAPREDUCE-6741 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1888f22eb4fa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d84ab8a Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6641/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6641/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6641/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 8s Maven dependency ordering for branch
        +1 mvninstall 7m 51s trunk passed
        +1 compile 1m 44s trunk passed
        +1 checkstyle 0m 38s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 1m 22s trunk passed
        +1 javadoc 0m 37s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 0m 45s the patch passed
        +1 compile 1m 32s the patch passed
        +1 javac 1m 32s the patch passed
        -1 checkstyle 0m 34s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 891 unchanged - 0 fixed = 892 total (was 891)
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 33s the patch passed
        +1 javadoc 0m 34s the patch passed
        +1 unit 2m 17s hadoop-mapreduce-client-core in the patch passed.
        +1 unit 9m 36s hadoop-mapreduce-client-app in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        33m 24s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820320/mapreduce6741.002.patch
        JIRA Issue MAPREDUCE-6741
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3765fb68d8b4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d84ab8a
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6643/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6643/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6643/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 7m 51s trunk passed +1 compile 1m 44s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 1m 22s trunk passed +1 javadoc 0m 37s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 45s the patch passed +1 compile 1m 32s the patch passed +1 javac 1m 32s the patch passed -1 checkstyle 0m 34s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 891 unchanged - 0 fixed = 892 total (was 891) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 33s the patch passed +1 javadoc 0m 34s the patch passed +1 unit 2m 17s hadoop-mapreduce-client-core in the patch passed. +1 unit 9m 36s hadoop-mapreduce-client-app in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 33m 24s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820320/mapreduce6741.002.patch JIRA Issue MAPREDUCE-6741 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3765fb68d8b4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d84ab8a Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6643/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6643/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6643/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        haibochen Haibo Chen added a comment -

        Another checkstyle fix.

        Show
        haibochen Haibo Chen added a comment - Another checkstyle fix.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 8s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 8s Maven dependency ordering for branch
        +1 mvninstall 7m 3s trunk passed
        +1 compile 1m 40s trunk passed
        +1 checkstyle 0m 36s trunk passed
        +1 mvnsite 2m 46s trunk passed
        +1 mvneclipse 0m 35s trunk passed
        +1 findbugs 1m 42s trunk passed
        +1 javadoc 0m 43s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        -1 mvninstall 0m 27s hadoop-mapreduce-client-core in the patch failed.
        -1 mvninstall 0m 18s hadoop-mapreduce-client-app in the patch failed.
        +1 compile 1m 55s the patch passed
        +1 javac 1m 55s the patch passed
        +1 checkstyle 0m 40s the patch passed
        -1 mvnsite 0m 19s hadoop-mapreduce-client-app in the patch failed.
        +1 mvneclipse 0m 27s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 16s hadoop-mapreduce-client-app in the patch failed.
        +1 javadoc 0m 36s the patch passed
        +1 unit 2m 18s hadoop-mapreduce-client-core in the patch passed.
        -1 unit 0m 17s hadoop-mapreduce-client-app in the patch failed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        25m 41s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820835/mapreduce6741.003.patch
        JIRA Issue MAPREDUCE-6741
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3ad5a79ace7b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d9aae22
        Default Java 1.8.0_101
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6647/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
        mvninstall https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6647/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
        mvnsite https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6647/artifact/patchprocess/patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
        findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6647/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6647/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6647/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6647/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 7m 3s trunk passed +1 compile 1m 40s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 2m 46s trunk passed +1 mvneclipse 0m 35s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 0m 43s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch -1 mvninstall 0m 27s hadoop-mapreduce-client-core in the patch failed. -1 mvninstall 0m 18s hadoop-mapreduce-client-app in the patch failed. +1 compile 1m 55s the patch passed +1 javac 1m 55s the patch passed +1 checkstyle 0m 40s the patch passed -1 mvnsite 0m 19s hadoop-mapreduce-client-app in the patch failed. +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 16s hadoop-mapreduce-client-app in the patch failed. +1 javadoc 0m 36s the patch passed +1 unit 2m 18s hadoop-mapreduce-client-core in the patch passed. -1 unit 0m 17s hadoop-mapreduce-client-app in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 25m 41s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820835/mapreduce6741.003.patch JIRA Issue MAPREDUCE-6741 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3ad5a79ace7b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d9aae22 Default Java 1.8.0_101 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6647/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt mvninstall https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6647/artifact/patchprocess/patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt mvnsite https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6647/artifact/patchprocess/patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6647/artifact/patchprocess/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6647/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6647/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6647/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        haibochen Haibo Chen added a comment -

        Don't know what the issue is, will retrigger another build tomorrow.

        Show
        haibochen Haibo Chen added a comment - Don't know what the issue is, will retrigger another build tomorrow.
        Hide
        haibochen Haibo Chen added a comment -

        upload a patch again to trigger another jenkin build

        Show
        haibochen Haibo Chen added a comment - upload a patch again to trigger another jenkin build
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 8s Maven dependency ordering for branch
        +1 mvninstall 7m 11s trunk passed
        +1 compile 1m 40s trunk passed
        +1 checkstyle 0m 37s trunk passed
        +1 mvnsite 0m 59s trunk passed
        +1 mvneclipse 0m 29s trunk passed
        +1 findbugs 1m 26s trunk passed
        +1 javadoc 0m 37s trunk passed
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 0m 44s the patch passed
        +1 compile 1m 34s the patch passed
        +1 javac 1m 34s the patch passed
        +1 checkstyle 0m 35s the patch passed
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 23s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 36s the patch passed
        +1 javadoc 0m 32s the patch passed
        +1 unit 2m 3s hadoop-mapreduce-client-core in the patch passed.
        +1 unit 8m 57s hadoop-mapreduce-client-app in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        31m 54s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821003/mapreduce6741.003.patch
        JIRA Issue MAPREDUCE-6741
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1bf27189482a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 204a205
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6648/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6648/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 7m 11s trunk passed +1 compile 1m 40s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 29s trunk passed +1 findbugs 1m 26s trunk passed +1 javadoc 0m 37s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 44s the patch passed +1 compile 1m 34s the patch passed +1 javac 1m 34s the patch passed +1 checkstyle 0m 35s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 36s the patch passed +1 javadoc 0m 32s the patch passed +1 unit 2m 3s hadoop-mapreduce-client-core in the patch passed. +1 unit 8m 57s hadoop-mapreduce-client-app in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 31m 54s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821003/mapreduce6741.003.patch JIRA Issue MAPREDUCE-6741 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1bf27189482a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 204a205 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6648/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6648/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks for the patch!

        Is it OK to expose the length of the original value? Wondering if the replacement value should be a constant number of asterisks or something like "<redacted>" or "<removed>".

        These properties are still visible via the AM UI while the job is running. Should they be redacted there as well?

        This should be making a copy of the configuration rather than doctoring it up directly with redacted values, tracking them in a separate map, then trying to patch it back later. If anything is asynchronously looking at the config and needs one of those redacted values then we're setting ourselves up for a random failure that's difficult to debug. Making a copy means we don't need to worry about tracking values and restoring anything later.

        There should be an entry in mapred-default.xml with an appropriate description documenting the new property.

        I recommend we drop the '-in-jhs' part of the property name since it's likely users will want this redacted everywhere eventually, even if it's not complete in this patch.

        Show
        jlowe Jason Lowe added a comment - Thanks for the patch! Is it OK to expose the length of the original value? Wondering if the replacement value should be a constant number of asterisks or something like "<redacted>" or "<removed>". These properties are still visible via the AM UI while the job is running. Should they be redacted there as well? This should be making a copy of the configuration rather than doctoring it up directly with redacted values, tracking them in a separate map, then trying to patch it back later. If anything is asynchronously looking at the config and needs one of those redacted values then we're setting ourselves up for a random failure that's difficult to debug. Making a copy means we don't need to worry about tracking values and restoring anything later. There should be an entry in mapred-default.xml with an appropriate description documenting the new property. I recommend we drop the '-in-jhs' part of the property name since it's likely users will want this redacted everywhere eventually, even if it's not complete in this patch.
        Hide
        haibochen Haibo Chen added a comment -

        Thanks a lot for your review, Jason Lowe! I will upload a new patch later to address your comments. For the replacement value, will do a constant number of asterisks plus ''<redacted>".

        Show
        haibochen Haibo Chen added a comment - Thanks a lot for your review, Jason Lowe ! I will upload a new patch later to address your comments. For the replacement value, will do a constant number of asterisks plus ''<redacted>".
        Hide
        haibochen Haibo Chen added a comment -

        Patch uploaded to address Jason's comment. The changes are specifially,
        1) values of redacted properties are replaced with a literal string "*********(redacted)"
        2) properties are also redacted from AM UI
        3) add the new configuration to mapred-default.xml
        4) In JHSEventHandler, a new configuration is copied from the original. In AM UI, the configuration object is loaded from the HDFS job.xml file every time the page is loaded, no need to make a copy.

        Show
        haibochen Haibo Chen added a comment - Patch uploaded to address Jason's comment. The changes are specifially, 1) values of redacted properties are replaced with a literal string "*********(redacted)" 2) properties are also redacted from AM UI 3) add the new configuration to mapred-default.xml 4) In JHSEventHandler, a new configuration is copied from the original. In AM UI, the configuration object is loaded from the HDFS job.xml file every time the page is loaded, no need to make a copy.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 8s Maven dependency ordering for branch
        +1 mvninstall 6m 56s trunk passed
        +1 compile 1m 39s trunk passed
        +1 checkstyle 0m 38s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 1m 28s trunk passed
        +1 javadoc 0m 37s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 0m 46s the patch passed
        +1 compile 1m 35s the patch passed
        +1 javac 1m 35s the patch passed
        -1 checkstyle 0m 33s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 2 new + 902 unchanged - 2 fixed = 904 total (was 904)
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 23s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 1m 34s the patch passed
        -1 javadoc 0m 19s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core generated 1 new + 2508 unchanged - 0 fixed = 2509 total (was 2508)
        +1 unit 2m 4s hadoop-mapreduce-client-core in the patch passed.
        +1 unit 9m 32s hadoop-mapreduce-client-app in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        32m 7s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822623/mapreduce6741.004.patch
        JIRA Issue MAPREDUCE-6741
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux da4d03c379d2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6255859
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6664/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        javadoc https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6664/artifact/patchprocess/diff-javadoc-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6664/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6664/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 6m 56s trunk passed +1 compile 1m 39s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 1m 28s trunk passed +1 javadoc 0m 37s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 46s the patch passed +1 compile 1m 35s the patch passed +1 javac 1m 35s the patch passed -1 checkstyle 0m 33s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 2 new + 902 unchanged - 2 fixed = 904 total (was 904) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 1m 34s the patch passed -1 javadoc 0m 19s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core generated 1 new + 2508 unchanged - 0 fixed = 2509 total (was 2508) +1 unit 2m 4s hadoop-mapreduce-client-core in the patch passed. +1 unit 9m 32s hadoop-mapreduce-client-app in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 32m 7s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822623/mapreduce6741.004.patch JIRA Issue MAPREDUCE-6741 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux da4d03c379d2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6255859 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6664/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt javadoc https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6664/artifact/patchprocess/diff-javadoc-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6664/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6664/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        haibochen Haibo Chen added a comment -

        Addressed checkstyle, javadoc issues reported by Jenkins.

        Show
        haibochen Haibo Chen added a comment - Addressed checkstyle, javadoc issues reported by Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 3m 34s Maven dependency ordering for branch
        +1 mvninstall 8m 54s trunk passed
        +1 compile 1m 53s trunk passed
        +1 checkstyle 0m 40s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvneclipse 0m 33s trunk passed
        +1 findbugs 1m 58s trunk passed
        +1 javadoc 0m 45s trunk passed
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 5s the patch passed
        +1 compile 2m 27s the patch passed
        +1 javac 2m 27s the patch passed
        -1 checkstyle 0m 39s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 902 unchanged - 2 fixed = 903 total (was 904)
        +1 mvnsite 1m 3s the patch passed
        +1 mvneclipse 0m 23s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 1m 38s the patch passed
        +1 javadoc 0m 33s the patch passed
        +1 unit 2m 4s hadoop-mapreduce-client-core in the patch passed.
        +1 unit 8m 55s hadoop-mapreduce-client-app in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        39m 37s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822643/mapreduce6741.005.patch
        JIRA Issue MAPREDUCE-6741
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 2718ab57f449 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0705489
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6665/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6665/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6665/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 3m 34s Maven dependency ordering for branch +1 mvninstall 8m 54s trunk passed +1 compile 1m 53s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 33s trunk passed +1 findbugs 1m 58s trunk passed +1 javadoc 0m 45s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 5s the patch passed +1 compile 2m 27s the patch passed +1 javac 2m 27s the patch passed -1 checkstyle 0m 39s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 902 unchanged - 2 fixed = 903 total (was 904) +1 mvnsite 1m 3s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 1m 38s the patch passed +1 javadoc 0m 33s the patch passed +1 unit 2m 4s hadoop-mapreduce-client-core in the patch passed. +1 unit 8m 55s hadoop-mapreduce-client-app in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 39m 37s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822643/mapreduce6741.005.patch JIRA Issue MAPREDUCE-6741 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 2718ab57f449 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0705489 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6665/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6665/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6665/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        haibochen Haibo Chen added a comment -

        One more checkstyle fix

        Show
        haibochen Haibo Chen added a comment - One more checkstyle fix
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 50s Maven dependency ordering for branch
        +1 mvninstall 6m 52s trunk passed
        +1 compile 1m 35s trunk passed
        +1 checkstyle 0m 39s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 29s trunk passed
        +1 findbugs 1m 24s trunk passed
        +1 javadoc 0m 37s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 0m 43s the patch passed
        +1 compile 1m 32s the patch passed
        +1 javac 1m 32s the patch passed
        +1 checkstyle 0m 35s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 0 new + 902 unchanged - 2 fixed = 902 total (was 904)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 1m 33s the patch passed
        +1 javadoc 0m 32s the patch passed
        +1 unit 2m 1s hadoop-mapreduce-client-core in the patch passed.
        +1 unit 8m 45s hadoop-mapreduce-client-app in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        31m 48s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822703/mapreduce6741.006.patch
        JIRA Issue MAPREDUCE-6741
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux c24c1e4058cd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0ad48aa
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6666/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6666/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 50s Maven dependency ordering for branch +1 mvninstall 6m 52s trunk passed +1 compile 1m 35s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 29s trunk passed +1 findbugs 1m 24s trunk passed +1 javadoc 0m 37s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 43s the patch passed +1 compile 1m 32s the patch passed +1 javac 1m 32s the patch passed +1 checkstyle 0m 35s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 0 new + 902 unchanged - 2 fixed = 902 total (was 904) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 33s the patch passed +1 javadoc 0m 32s the patch passed +1 unit 2m 1s hadoop-mapreduce-client-core in the patch passed. +1 unit 8m 45s hadoop-mapreduce-client-app in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 31m 48s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822703/mapreduce6741.006.patch JIRA Issue MAPREDUCE-6741 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux c24c1e4058cd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0ad48aa Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6666/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6666/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        +1 lgtm. Committing this.

        Show
        jlowe Jason Lowe added a comment - +1 lgtm. Committing this.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #10243 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10243/)
        MAPREDUCE-6741. Add MR support to redact job conf properties. (jlowe: rev 4aba858750900de25940c16211c21de4addd1926)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/util/MRJobConfUtil.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestBlocks.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/dao/ConfInfo.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/jobhistory/TestJobHistoryEventHandler.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10243 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10243/ ) MAPREDUCE-6741 . Add MR support to redact job conf properties. (jlowe: rev 4aba858750900de25940c16211c21de4addd1926) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/util/MRJobConfUtil.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/webapp/TestBlocks.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/webapp/dao/ConfInfo.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/jobhistory/TestJobHistoryEventHandler.java
        Hide
        jlowe Jason Lowe added a comment -

        Thanks, Haibo Chen! I committed this to trunk and branch-2.

        Show
        jlowe Jason Lowe added a comment - Thanks, Haibo Chen ! I committed this to trunk and branch-2.
        Hide
        haibochen Haibo Chen added a comment -

        Thanks again for your kind reviews, Jason!

        Show
        haibochen Haibo Chen added a comment - Thanks again for your kind reviews, Jason!
        Hide
        kasha Karthik Kambatla added a comment -

        Given potentially sensitive data, we should probably pull this into 2.8. /cc Sangjin Lee for 2.6.x and 2.7.x releases.

        Show
        kasha Karthik Kambatla added a comment - Given potentially sensitive data, we should probably pull this into 2.8. /cc Sangjin Lee for 2.6.x and 2.7.x releases.
        Hide
        haibochen Haibo Chen added a comment -

        Reopen to upload a branch-2.8 patch

        Show
        haibochen Haibo Chen added a comment - Reopen to upload a branch-2.8 patch
        Hide
        haibochen Haibo Chen added a comment -

        uploading a patch for branch-2.8

        Show
        haibochen Haibo Chen added a comment - uploading a patch for branch-2.8
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 29s Maven dependency ordering for branch
        +1 mvninstall 7m 9s branch-2.8 passed
        +1 compile 1m 1s branch-2.8 passed with JDK v1.8.0_101
        +1 compile 1m 16s branch-2.8 passed with JDK v1.7.0_111
        +1 checkstyle 0m 35s branch-2.8 passed
        +1 mvnsite 1m 1s branch-2.8 passed
        +1 mvneclipse 0m 30s branch-2.8 passed
        +1 findbugs 1m 47s branch-2.8 passed
        +1 javadoc 0m 35s branch-2.8 passed with JDK v1.8.0_101
        +1 javadoc 0m 42s branch-2.8 passed with JDK v1.7.0_111
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 58s the patch passed with JDK v1.8.0_101
        +1 javac 0m 58s the patch passed
        +1 compile 1m 13s the patch passed with JDK v1.7.0_111
        +1 javac 1m 13s the patch passed
        +1 checkstyle 0m 31s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 0 new + 839 unchanged - 2 fixed = 839 total (was 841)
        +1 mvnsite 0m 55s the patch passed
        +1 mvneclipse 0m 25s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        +1 findbugs 2m 9s the patch passed
        +1 javadoc 0m 31s the patch passed with JDK v1.8.0_101
        +1 javadoc 0m 36s the patch passed with JDK v1.7.0_111
        +1 unit 1m 50s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_101.
        -1 unit 9m 3s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_101.
        +1 unit 2m 11s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_111.
        +1 unit 10m 8s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_111.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        48m 21s



        Reason Tests
        JDK v1.8.0_101 Failed junit tests hadoop.mapreduce.v2.app.job.impl.TestJobImpl



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:5af2af1
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831664/mapreduce6741.branch-2.8.patch
        JIRA Issue MAPREDUCE-6741
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 4465b7488bff 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.8 / 3656b84
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6750/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_101.txt
        unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6750/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_101.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6750/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6750/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 29s Maven dependency ordering for branch +1 mvninstall 7m 9s branch-2.8 passed +1 compile 1m 1s branch-2.8 passed with JDK v1.8.0_101 +1 compile 1m 16s branch-2.8 passed with JDK v1.7.0_111 +1 checkstyle 0m 35s branch-2.8 passed +1 mvnsite 1m 1s branch-2.8 passed +1 mvneclipse 0m 30s branch-2.8 passed +1 findbugs 1m 47s branch-2.8 passed +1 javadoc 0m 35s branch-2.8 passed with JDK v1.8.0_101 +1 javadoc 0m 42s branch-2.8 passed with JDK v1.7.0_111 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 45s the patch passed +1 compile 0m 58s the patch passed with JDK v1.8.0_101 +1 javac 0m 58s the patch passed +1 compile 1m 13s the patch passed with JDK v1.7.0_111 +1 javac 1m 13s the patch passed +1 checkstyle 0m 31s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 0 new + 839 unchanged - 2 fixed = 839 total (was 841) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 2m 9s the patch passed +1 javadoc 0m 31s the patch passed with JDK v1.8.0_101 +1 javadoc 0m 36s the patch passed with JDK v1.7.0_111 +1 unit 1m 50s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_101. -1 unit 9m 3s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_101. +1 unit 2m 11s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_111. +1 unit 10m 8s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 48m 21s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.mapreduce.v2.app.job.impl.TestJobImpl Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831664/mapreduce6741.branch-2.8.patch JIRA Issue MAPREDUCE-6741 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 4465b7488bff 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 3656b84 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6750/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6750/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_101.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6750/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6750/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        +1 for the branch-2.8 patch. The TestJobImpl failure appears to be unrelated, and the test passes for me locally with the patch applied.

        Show
        jlowe Jason Lowe added a comment - +1 for the branch-2.8 patch. The TestJobImpl failure appears to be unrelated, and the test passes for me locally with the patch applied.
        Hide
        jlowe Jason Lowe added a comment -

        Committed to branch-2.8 and branch-2.7.

        Show
        jlowe Jason Lowe added a comment - Committed to branch-2.8 and branch-2.7.
        Hide
        sjlee0 Sangjin Lee added a comment -

        According to the discussion we were having on the release cadence and EOL, the 2.6.x line could be EOLed some time in Nov. 2016. Although it is far from being concluded, the fate of another 2.6 release is at least uncertain. Why don't we hold off on backporting it to 2.6?

        We should probably raise the release cadence and EOL topic again and conclude it at some point...

        Show
        sjlee0 Sangjin Lee added a comment - According to the discussion we were having on the release cadence and EOL, the 2.6.x line could be EOLed some time in Nov. 2016. Although it is far from being concluded, the fate of another 2.6 release is at least uncertain. Why don't we hold off on backporting it to 2.6? We should probably raise the release cadence and EOL topic again and conclude it at some point...

          People

          • Assignee:
            haibochen Haibo Chen
            Reporter:
            haibochen Haibo Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development