Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6717

Remove deprecated StringUtils.getFormattedTimeWithDiff

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      MAPREDUCE-6542 deprecated StringUtils.getFormattedTimeWithDiff(DateFormat, long, long), so it should be removed later.
      This method can be removed in branch-2 because StringUtils is not @Public.

      1. MAPREDUCE-6717-branch-2.01.patch
        2 kB
        Akira Ajisaka
      2. MAPREDUCE-6717_1.patch
        2 kB
        Shen Yinjie

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #10060 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10060/)
          MAPREDUCE-6717. Remove deprecated StringUtils.getFormattedTimeWithDiff. (aajisaka: rev d1626a7b37472f8b76bfbd5ee484cefa7cba7d3d)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10060 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10060/ ) MAPREDUCE-6717 . Remove deprecated StringUtils.getFormattedTimeWithDiff. (aajisaka: rev d1626a7b37472f8b76bfbd5ee484cefa7cba7d3d) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Shen Yinjie for the contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Shen Yinjie for the contribution.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, checking this in.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, checking this in.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 16m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 9s branch-2 passed
          +1 compile 7m 1s branch-2 passed with JDK v1.8.0_91
          +1 compile 6m 38s branch-2 passed with JDK v1.7.0_101
          +1 checkstyle 0m 26s branch-2 passed
          +1 mvnsite 0m 58s branch-2 passed
          +1 mvneclipse 0m 15s branch-2 passed
          +1 findbugs 1m 46s branch-2 passed
          +1 javadoc 0m 50s branch-2 passed with JDK v1.8.0_91
          +1 javadoc 0m 57s branch-2 passed with JDK v1.7.0_101
          +1 mvninstall 0m 46s the patch passed
          +1 compile 6m 14s the patch passed with JDK v1.8.0_91
          +1 javac 6m 14s the patch passed
          +1 compile 6m 39s the patch passed with JDK v1.7.0_101
          +1 javac 6m 39s the patch passed
          +1 checkstyle 0m 25s the patch passed
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 1m 57s the patch passed
          +1 javadoc 0m 47s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 58s the patch passed with JDK v1.7.0_101
          +1 unit 8m 4s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 9m 42s hadoop-common in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 25s The patch does not generate ASF License warnings.
          80m 45s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816659/MAPREDUCE-6717-branch-2.01.patch
          JIRA Issue MAPREDUCE-6717
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f6ddb23b5284 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 8a94402
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6597/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6597/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6597/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 16m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 9s branch-2 passed +1 compile 7m 1s branch-2 passed with JDK v1.8.0_91 +1 compile 6m 38s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 0m 26s branch-2 passed +1 mvnsite 0m 58s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed +1 findbugs 1m 46s branch-2 passed +1 javadoc 0m 50s branch-2 passed with JDK v1.8.0_91 +1 javadoc 0m 57s branch-2 passed with JDK v1.7.0_101 +1 mvninstall 0m 46s the patch passed +1 compile 6m 14s the patch passed with JDK v1.8.0_91 +1 javac 6m 14s the patch passed +1 compile 6m 39s the patch passed with JDK v1.7.0_101 +1 javac 6m 39s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 16s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 1m 57s the patch passed +1 javadoc 0m 47s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 58s the patch passed with JDK v1.7.0_101 +1 unit 8m 4s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 9m 42s hadoop-common in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 80m 45s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816659/MAPREDUCE-6717-branch-2.01.patch JIRA Issue MAPREDUCE-6717 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f6ddb23b5284 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 8a94402 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6597/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6597/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6597/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM. Renamed the patch to run precommit job in branch-2. Let's see what happens.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM. Renamed the patch to run precommit job in branch-2. Let's see what happens.
          Hide
          shenyinjie Shen Yinjie added a comment - - edited

          Hi,Akira Ajisaka,would you take a look at this patch?

          Show
          shenyinjie Shen Yinjie added a comment - - edited Hi, Akira Ajisaka ,would you take a look at this patch?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 24s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 15s trunk passed
          +1 compile 6m 32s trunk passed
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 0m 52s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 18s trunk passed
          +1 javadoc 0m 46s trunk passed
          +1 mvninstall 0m 37s the patch passed
          +1 compile 6m 27s the patch passed
          +1 javac 6m 27s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 0m 53s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 27s the patch passed
          +1 javadoc 0m 45s the patch passed
          +1 unit 6m 54s hadoop-common in the patch passed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          35m 23s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816574/MAPREDUCE-6717_1.patch
          JIRA Issue MAPREDUCE-6717
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ce07af4e5756 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a3f93be
          Default Java 1.8.0_91
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6595/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6595/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 15s trunk passed +1 compile 6m 32s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 27s the patch passed +1 javac 6m 27s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 27s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 6m 54s hadoop-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 35m 23s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816574/MAPREDUCE-6717_1.patch JIRA Issue MAPREDUCE-6717 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ce07af4e5756 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a3f93be Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6595/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6595/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 17s trunk passed
          +1 compile 6m 32s trunk passed
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 0m 53s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 19s trunk passed
          +1 javadoc 0m 45s trunk passed
          +1 mvninstall 0m 37s the patch passed
          +1 compile 6m 28s the patch passed
          +1 javac 6m 28s the patch passed
          -1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 1 new + 85 unchanged - 0 fixed = 86 total (was 85)
          +1 mvnsite 0m 53s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 26s the patch passed
          +1 javadoc 0m 45s the patch passed
          +1 unit 6m 58s hadoop-common in the patch passed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          35m 29s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816552/MAPREDUCE-6717.patch
          JIRA Issue MAPREDUCE-6717
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a102127e38fa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a3f93be
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6594/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6594/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6594/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 17s trunk passed +1 compile 6m 32s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 19s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 28s the patch passed +1 javac 6m 28s the patch passed -1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 1 new + 85 unchanged - 0 fixed = 86 total (was 85) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 26s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 6m 58s hadoop-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 35m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816552/MAPREDUCE-6717.patch JIRA Issue MAPREDUCE-6717 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a102127e38fa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a3f93be Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6594/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6594/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6594/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          shenyinjie Shen Yinjie added a comment -

          changes in trunk

          Show
          shenyinjie Shen Yinjie added a comment - changes in trunk

            People

            • Assignee:
              shenyinjie Shen Yinjie
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development