[MAPREDUCE-6710] Job CommitterEventHandler waitForValidCommitWindow may wait forever

• Type: Bug
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.5.0, 2.6.1, 2.8.0, 3.0.0-alpha1
• Component/s: applicationmaster
• Flags: Patch, Important
• Assignee: Unassigned
• Reporter: ChenFolin
• Created: 03/Jun/16 10:54
• Updated: 03/Jun/16 11:19

Description

The callBack Runnable may run after runOnNextHeartbeat but before wait(), if that happens, it will wait forever.

So I think the wait() must set timeout.

CommitterEventHandler#waitForValidCommitWindow
while (now - lastHeartbeatTime > commitWindowMs) {
rmHeartbeatHandler.runOnNextHeartbeat(new Runnable() {
@Override
public void run() {
synchronized (EventProcessor.this)

{ EventProcessor.this.notify(); }

}
});

wait();
lastHeartbeatTime = rmHeartbeatHandler.getLastHeartbeatTime();
now = context.getClock().getTime();
}