Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6701

application master log can not be available when clicking jobhistory's am logs link

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.9.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: jobhistoryserver
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Flags:
      Patch

      Description

      In history server webapp, application master logs link is wrong. it shows "No logs available for container container_1462419429440_0003_01_000001". It direct to a wrong nodemanager http port instead of a node manager' container managerment port. I think YARN-4701 brought this bug

      1. yarn5041.001.patch
        2 kB
        Haibo Chen
      2. yarn5041.002.patch
        5 kB
        Haibo Chen

        Issue Links

          Activity

          Hide
          jlowe Jason Lowe added a comment -

          It would be a significant regression if jobhistory AM log links no longer work after YARN-4701. Haibo Chen or Robert Kanter could you take a look?

          Show
          jlowe Jason Lowe added a comment - It would be a significant regression if jobhistory AM log links no longer work after YARN-4701 . Haibo Chen or Robert Kanter could you take a look?
          Hide
          rkanter Robert Kanter added a comment -

          You're right, the AM logs link in the JHS has the wrong port in the URL, so it doesn't work anymore. I've discussed this with Haibo Chen, and he's looking into a fix.

          Show
          rkanter Robert Kanter added a comment - You're right, the AM logs link in the JHS has the wrong port in the URL, so it doesn't work anymore. I've discussed this with Haibo Chen , and he's looking into a fix.
          Hide
          haibochen Haibo Chen added a comment -

          The patch is tested locally. IMO, the unit test is too difficult to create given that the render() of HsJobBlock calls a lot of methods that calls injector. Any suggestion of how to unit test this will be appreciated.

          Show
          haibochen Haibo Chen added a comment - The patch is tested locally. IMO, the unit test is too difficult to create given that the render() of HsJobBlock calls a lot of methods that calls injector. Any suggestion of how to unit test this will be appreciated.
          Hide
          rkanter Robert Kanter added a comment -

          Haibo Chen, it looks like Jenkins ran, but didn't post a comment for some reason. I see 4 test failures that look related. Can you take a look? See https://builds.apache.org/job/PreCommit-YARN-Build/11445/

          Show
          rkanter Robert Kanter added a comment - Haibo Chen , it looks like Jenkins ran, but didn't post a comment for some reason. I see 4 test failures that look related. Can you take a look? See https://builds.apache.org/job/PreCommit-YARN-Build/11445/
          Hide
          haibochen Haibo Chen added a comment -

          Thanks for letting me know. The test failures were indeed caused by my change. Updated the patch to fix the failures.

          Show
          haibochen Haibo Chen added a comment - Thanks for letting me know. The test failures were indeed caused by my change. Updated the patch to fix the failures.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 45s trunk passed
          +1 compile 0m 14s trunk passed with JDK v1.8.0_91
          +1 compile 0m 17s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 0m 24s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 32s trunk passed
          +1 javadoc 0m 13s trunk passed with JDK v1.8.0_91
          +1 javadoc 0m 16s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 18s the patch passed
          +1 compile 0m 13s the patch passed with JDK v1.8.0_91
          +1 javac 0m 13s the patch passed
          +1 compile 0m 15s the patch passed with JDK v1.7.0_95
          +1 javac 0m 15s the patch passed
          +1 checkstyle 0m 13s the patch passed
          +1 mvnsite 0m 21s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 1s Patch has no whitespace issues.
          +1 findbugs 0m 41s the patch passed
          +1 javadoc 0m 10s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 12s the patch passed with JDK v1.7.0_95
          +1 unit 5m 41s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_91.
          +1 unit 6m 8s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          25m 1s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803912/yarn5041.002.patch
          JIRA Issue YARN-5041
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux bc108c257f30 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1f2794b
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11455/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11455/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 45s trunk passed +1 compile 0m 14s trunk passed with JDK v1.8.0_91 +1 compile 0m 17s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 24s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 32s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 16s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 18s the patch passed +1 compile 0m 13s the patch passed with JDK v1.8.0_91 +1 javac 0m 13s the patch passed +1 compile 0m 15s the patch passed with JDK v1.7.0_95 +1 javac 0m 15s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 1s Patch has no whitespace issues. +1 findbugs 0m 41s the patch passed +1 javadoc 0m 10s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 12s the patch passed with JDK v1.7.0_95 +1 unit 5m 41s hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_91. +1 unit 6m 8s hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 25m 1s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803912/yarn5041.002.patch JIRA Issue YARN-5041 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bc108c257f30 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1f2794b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11455/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs Console output https://builds.apache.org/job/PreCommit-YARN-Build/11455/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          +1 lgtm. Will commit this tomorrow if there are no objections.

          Show
          jlowe Jason Lowe added a comment - +1 lgtm. Will commit this tomorrow if there are no objections.
          Hide
          rkanter Robert Kanter added a comment -

          +1 LGTM too

          Show
          rkanter Robert Kanter added a comment - +1 LGTM too
          Hide
          jlowe Jason Lowe added a comment -

          Thanks to Haibo Chen for the contribution and to Robert Kanter for additional review! I committed this to trunk and branch-2.

          Show
          jlowe Jason Lowe added a comment - Thanks to Haibo Chen for the contribution and to Robert Kanter for additional review! I committed this to trunk and branch-2.
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Hadoop-trunk-Commit #9793 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9793/)
          MAPREDUCE-6701. application master log can not be available when (jlowe: rev 12fa4ec141f8d0cb105b6f60c3739a4b26890fd5)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobs.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/dao/AMAttemptInfo.java
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Hadoop-trunk-Commit #9793 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9793/ ) MAPREDUCE-6701 . application master log can not be available when (jlowe: rev 12fa4ec141f8d0cb105b6f60c3739a4b26890fd5) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobBlock.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/TestHsWebServicesJobs.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/dao/AMAttemptInfo.java

            People

            • Assignee:
              haibochen Haibo Chen
              Reporter:
              chenyukang chenyukang
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development